Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

[GraphQl] Fixed response for removeCouponFromCart mutation #4173

Closed
wants to merge 2 commits into from

Conversation

rogyar
Copy link
Contributor

@rogyar rogyar commented Apr 4, 2019

This PR is a:

  • New topic
  • Content update
  • Content fix or rewrite
  • Bug fix or improvement

Summary

This PR introduces a fix for response of removeCouponFromCart mutation documented in https://devdocs.magento.com/guides/v2.3/graphql/reference/quote.html. After coupon is removed from the shopping cart, the response contains no coupon code (currently the response contains the same coupon code that was previously applied).

Additional information

List all affected URLs

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@osrecio osrecio self-requested a review April 5, 2019 07:03
@osrecio osrecio self-assigned this Apr 5, 2019
Copy link
Member

@osrecio osrecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in local environment and your PR is valid @rogyar .

This PR will be merged soon.

Thanks!

@keharper keharper added xx2.3.2 Magento 2.3.2 changes Technical Updates to the code or processes that alter the technical content of the doc labels Apr 11, 2019
@keharper
Copy link
Contributor

@rogyar same comment here as elsewhere.

I don't expect to merge this for another week or two. I'm in the processing of scoping the documentation impact of all PRs and issues expected to make it into the 2.3.2 release.

It would be helpful to me if you did the following:

  • Provide a link to the PR that enabled this mutation (if known)
  • Change the branch to magento:develop.

@keharper keharper self-assigned this Apr 11, 2019
@rogyar rogyar changed the base branch from master to develop April 23, 2019 10:36
@rogyar
Copy link
Contributor Author

rogyar commented Apr 23, 2019

Hi @keharper. I've created another PR to the develop branch with all details there. Please, take a look when you have time.

#4318

Closing this one, thank you

@ghost
Copy link

ghost commented Apr 23, 2019

Hi @rogyar, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Partner: Atwix partners-contribution PR created by Magento partner Technical Updates to the code or processes that alter the technical content of the doc xx2.3.2 Magento 2.3.2 changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants