Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

added missing php tags #4497

Merged
merged 3 commits into from
May 13, 2019
Merged

added missing php tags #4497

merged 3 commits into from
May 13, 2019

Conversation

gaurav-473
Copy link
Contributor

This PR is a:

  • Content fix or rewrite

Summary

When this pull request is merged, it will...
it will add php tag in examples

Additional information

List all affected URLs

https://devdocs.magento.com/guides/v2.3/extension-dev-guide/plugins.html
https://devdocs.magento.com/guides/v2.2/extension-dev-guide/plugins.html

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 12, 2019

CLA assistant check
All committers have signed the CLA.

@gaurav-473
Copy link
Contributor Author

#ContributionDay

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@rogyar rogyar self-assigned this May 12, 2019
@lorikrell lorikrell added the Contribution Day Issues and PRs for Contribution Days! Groomed and ready to work. label May 12, 2019
Copy link

@lorikrell lorikrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, @gauravagarwal1001! And the review, @rogyar !

I'll perform tests, and get this merged to DevDocs! We appreciate the Contribution Day contribution!

@lorikrell lorikrell added Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies 2.2.x labels May 12, 2019
@dobooth dobooth changed the base branch from master to small_changes May 13, 2019 14:25
@dobooth dobooth merged commit f551c43 into magento:small_changes May 13, 2019
@ghost
Copy link

ghost commented May 13, 2019

Hi @gauravagarwal1001, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@dobooth
Copy link
Contributor

dobooth commented May 13, 2019

Thanks @gauravagarwal1001 !

@dobooth dobooth mentioned this pull request May 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.2.x Community Insider: Cedcommerce community-insider-contribution Contribution Day Issues and PRs for Contribution Days! Groomed and ready to work. Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants