Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

magento/devdocs#7376: REST: Inventory In-Store Pickup endpoints. #7383

Conversation

swnsma
Copy link
Contributor

@swnsma swnsma commented Jun 9, 2020

Purpose of this pull request

#7376

Affected DevDocs pages

  • modules/inventory/in-store-pickup.md

Links to Magento source code

  • \Magento\InventoryInStorePickupApi\Api\GetPickupLocationsInterface
  • \Magento\InventoryInStorePickupSalesApi\Api\NotifyOrdersAreReadyForPickupInterface

Q:
We already have a wiki page for new REST endpoints and adjustment of already available REST endpoints: https://github.com/magento/inventory/wiki/In-Store-Pickup-API-Tutorials
Should we add "adjustments" as a part of this page or create new one?

whatsnew
Added two new REST endpoints that add support for the Inventory Management In-store Pickup feature.

@swnsma swnsma requested a review from keharper June 9, 2020 15:39
@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@keharper keharper added 2.4.0 Community Docs impacted by community code contribution New Topic A major update published as an entirely new document labels Jun 10, 2020
Copy link
Contributor

@keharper keharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swnsma Be sure to update the src/guides/v2.4/rest/modules/inventory/manage-sources.md file to include the new attributes.

It is not necessary to update the tutorial, because the tutorial needs to be refactored to accommodate In-Store Pickup.


The `GET /V1/inventory/in-store-pickup/pickup-locations` endpoint searches for and filters on pickup locations, allowing the shopper to quickly narrow the results.

Search terms, filters, and other attributes are specified as query parameters in the URL. This endpoint uses different a different syntax than other Magento GET calls that send `searchCriteria` parameters. Instead, the `GET /V1/inventory/in-store-pickup/pickup-locations` endpoint requires that each query parameter begins with `searchRequest`. The `scopeCode` parameter is required. All other parameters are optional.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"uses different a different"

Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @swnsma, the overall doc looks good to me. Thank you :)

The only thing I would like to add is information about auth permissions.
It would be nice to mention that inventoryInStorePickupSalesApiNotifyOrdersAreReadyForPickupV1 requires the appropriate admin persmissions (resource) Magento_InventoryInStorePickupApi::notify_orders_are_ready_for_pickup.
When inventoryInStorePickupApiGetPickupLocationsV1 has guest permissions and does't require authentication.
But it's not critical and up to you.

Thank you!

oleksandrkravchuk and others added 3 commits June 11, 2020 18:17
Copy link
Contributor

@keharper keharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@keharper
Copy link
Contributor

running tests

@keharper keharper merged commit 8d4b214 into magento:master Jun 12, 2020
@ghost
Copy link

ghost commented Jun 12, 2020

Hi @swnsma, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.4.0 Community Docs impacted by community code contribution New Topic A major update published as an entirely new document Partner: Vaimo partners-contribution PR created by Magento partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants