7786-Changed the code for afterSave function in adding-attributes.md file

[chiranjeevi-cj]

Purpose of this pull request

This pull request (PR)
https://devdocs.magento.com/guides/v2.4/extension-dev-guide/extension_attributes/adding-attributes.html

Directly following the general patterns described on this page - for an extension attribute on a product, with a plugin connected to the product repository - the afterSave function will not update the extension attribute. For example, making an API call with updated extension attribute will leave it unchanged.

Description

Essentially, the data in the product instance returned as the result of a save call (passed as the 2nd parameter to an 'after' plugin function) is not what was sent via the API.

After a little digging, the data that reaches the beforeSave function is correct. However, the final step in the product repository save process is a get call, presumably to refresh data, which correspondingly triggers the afterGet function to (re-)populate the extension attributes on the product returned as the result.

The code example on the page is using the ProductInterface that is the result returned from the function, due to the attribute sequence, hence why it can't / won't update the extension attribute.

However, it should also be noted that is specifically a peculiarity of the product repository and does not necessarily hold true for other repositories.

Affected DevDocs pages

• https://devdocs.magento.com/guides/v2.4/extension-dev-guide/extension_attributes/adding-attributes.html

Fixes #7786

[BarnyShergold]

Thanks for your contribution - just some formatting queries

[BarnyShergold]

Indenting on this line (and next 2) should have one less space

[BarnyShergold]

Normally in PHP single line comments are done with // e.g. // result from the save call
Is there a reason the /** .... **/ format is used?

[chiranjeevi-cj]

As in the site(https://devdocs.magento.com/guides/v2.4/extension-dev-guide/extension_attributes/adding-attributes.html), every comment was done with /** .... **/ that's why I followed it.
Should I need to change?

[BarnyShergold]

No - if it's being used elsewhere then you should stick to it for convention. It's not a must.

[chiranjeevi-cj]

@BarnyShergold As in the site(https://devdocs.magento.com/guides/v2.4/extension-dev-guide/extension_attributes/adding-attributes.html), every comment was done with /** .... **/ that's why I followed it.
Should I need to change?

[chiranjeevi-cj]

@BarnyShergold Is there anything that needs to be changed?

[BarnyShergold]

Thanks for your contribution!

[dobooth]

running tests

[ghost]

Hi @chiranjeevi-cj, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.