Skip to content
This repository was archived by the owner on Dec 19, 2019. It is now read-only.

Hide product attributes not intended for storefront #25

Closed
paliarush opened this issue May 16, 2018 · 1 comment
Closed

Hide product attributes not intended for storefront #25

paliarush opened this issue May 16, 2018 · 1 comment
Assignees
Labels

Comments

@paliarush
Copy link
Contributor

paliarush commented May 16, 2018

In Admin, if all of the following product attribute storefront properties are set to No, then it should be filtered out (not exposed by GraphQL):

  • Comparable on Storefront
  • Use in Layered Navigation
  • Use in Search Results Layered Navigation
  • Visible on Catalog Pages on Storefront
  • Used in Product Listing
  • Used for Sorting in Product Listing

Otherwise (if any of the above are Yes), attribute values and attribute metadata should be accessible in GraphQL

Changes should be covered with web API functional tests. See \Magento\GraphQl\Catalog\ProductViewTest::testQueryAllFieldsSimpleProduct as an example.

@paliarush paliarush added the bug Something isn't working label May 16, 2018
@paliarush paliarush changed the title Hide product attributes not intended for Storefront Hide product attributes not intended for storefront May 16, 2018
@vovsky vovsky closed this as completed Jun 30, 2018
@vovsky vovsky reopened this Jun 30, 2018
@vovsky vovsky self-assigned this Jun 30, 2018
@naydav
Copy link
Contributor

naydav commented Sep 26, 2018

#103

@naydav naydav closed this as completed Sep 26, 2018
@naydav naydav added this to the Release: 2.3.0 milestone Dec 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants