Skip to content
This repository was archived by the owner on Dec 19, 2019. It is now read-only.

Make category query compatible with staging #96

Closed
paliarush opened this issue Jun 21, 2018 · 1 comment
Closed

Make category query compatible with staging #96

paliarush opened this issue Jun 21, 2018 · 1 comment
Assignees
Labels
bug Something isn't working commerce Magento Commerce is required for work on this ticket Component: CatalogGraphQl good first issue Good for newcomers small

Comments

@paliarush
Copy link
Contributor

Preconditions

  1. Magento Commerce is installed (not just open source)
  2. At least one category in the system has a scheduled update

Steps to reproduce

  1. Create a new category
  2. Request this category by ID via GraphQL API:
{
  category(id: 4) {
    name
    products(sort: {sku: ASC}) {
      total_count
      items {
        sku
      }
    }
  }
}

Expected result

  1. Requested category info should be returned in the result

Actual result

  1. Category in the response is null

Additional info

  • Possible fix is to replace getLinkField() with getIdentifierField() here.
  • Existing tests should be adjusted. At least this one \Magento\GraphQl\Catalog\CategoryTest::testAnchorCategory
@paliarush paliarush added bug Something isn't working good first issue Good for newcomers additional-coverage small commerce Magento Commerce is required for work on this ticket labels Jun 21, 2018
magento-engcom-team added a commit that referenced this issue Jul 24, 2018
 - Merge Pull Request #99 from magento/graphql-ce:96-compatibility-with-content-staging
 - Merged commits:
   1. e79f381
magento-engcom-team pushed a commit that referenced this issue Jul 24, 2018
Accepted Public Pull Requests:
 - magento/magento2#16893: [Forwardport] FIX for issue#14869 - Wrong price at backend after update (by @mage2pratik)
 - magento/magento2#17020: [Forwardport] hide cookie notice instead of reloading site (by @torhoehn)
 - magento/magento2#17014: [Forwardport] Fixes white color coding standard. (by @chirag-wagento)
 - magento/magento2#17016: [Forwardport] Avoid undefined index warning when using uppercase reserved word (by @FreekVandeursen)
 - magento/magento2#17017: [Forwardport] Wrong namespace defined in compare.phtml (by @ronak2ram)
 - magento/magento2#16997: [Forwardport] Corrected Magento_Framework's test xml file. (by @ihor-sviziev)
 - magento/magento2#16996: [Forwardport] Updated Magento_Newsletter's block file. (by @ihor-sviziev)
 - magento/magento2#16994: [Forwardport] Responsive Design Footers bottom of screen on mobile devices #15118 (by @ihor-sviziev)
 - magento/magento2#16993: [Forwardport] FIXED - appended payment code to ID field to make it unique (by @ihor-sviziev)
 - magento/magento2#16998: [Forwardport] Added 'title' attribute to 'a' link. (by @ihor-sviziev)
 - magento/magento2#16973: [Forwardport] Removed double occurrence of  keywords in sentences. (by @gelanivishal)
 - #126: 120 implement store configs coverage (by @VitaliyBoyko)
 - #99: #96 Make category query compatible with staging (by @roma-glushko)
 - magento/magento2#16734: [forwardport] #16559 fix icon color variable naming  (by @Karlasa)


Fixed GitHub Issues:
 - magento/magento2#14869: M 2.2.3 price per website - wrong price at backend by a create order after update (reported by @Webroju) has been fixed in magento/magento2#16893 by @mage2pratik in 2.3-develop branch
   Related commits:
     1. 49926d7
     2. 35b968e

 - magento/magento2#15118: Responsive Design, Footers do not snap to bottom of screen on mobile devices (reported by @gwharton) has been fixed in magento/magento2#16994 by @ihor-sviziev in 2.3-develop branch
   Related commits:
     1. f7228d0

 - magento/magento2#13692: In payment step of checkout I cannot unselect #billing-save-in-address-book checkbox in non-first payment method (reported by @NeosKnowledgeBasePluswerk) has been fixed in magento/magento2#16993 by @ihor-sviziev in 2.3-develop branch
   Related commits:
     1. a659f4b

 - magento/magento2#120: Default trigger coupon via URL (reported by @seansan) has been fixed in #126 by @VitaliyBoyko in 2.3-develop branch
   Related commits:
     1. e1f53d4
     2. 5229cd6
     3. af4b258
     4. 3b64955
     5. b5a2a98
     6. e85a6e5
     7. 8f3c6e9
@naydav
Copy link
Contributor

naydav commented Sep 26, 2018

#99

@naydav naydav closed this as completed Sep 26, 2018
magento-engcom-team pushed a commit that referenced this issue Oct 12, 2019
Pushing MC-20335 changes to MC-19451 branch
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working commerce Magento Commerce is required for work on this ticket Component: CatalogGraphQl good first issue Good for newcomers small
Projects
None yet
Development

No branches or pull requests

4 participants