Skip to content
This repository was archived by the owner on Dec 19, 2019. It is now read-only.

[Test coverage] Cover exceptions in AssignShippingAddressToCart, AssignBillingAddressToCart #977

Closed
TomashKhamlai opened this issue Oct 1, 2019 · 1 comment
Closed

[Test coverage] Cover exceptions in AssignShippingAddressToCart, AssignBillingAddressToCart #977

TomashKhamlai opened this issue Oct 1, 2019 · 1 comment
Labels
Component: QuoteGraphQl good first issue Good for newcomers test-coverage
Milestone
Release: 2.3.4

Comments

@TomashKhamlai
Copy link
Contributor

Description:

Cover exceptions with api-functional tests:

graphql-ce/app/code/Magento/QuoteGraphQl/Model/Cart/AssignShippingAddressToCart.php

Line 54 in e02dc94

throw new GraphQlInputException(__($e->getMessage()), $e);

graphql-ce/app/code/Magento/QuoteGraphQl/Model/Cart/AssignBillingAddressToCart.php

Line 54 in e02dc94

throw new GraphQlNoSuchEntityException(__($e->getMessage()), $e);

graphql-ce/app/code/Magento/QuoteGraphQl/Model/Cart/AssignBillingAddressToCart.php

Line 56 in e02dc94

throw new GraphQlInputException(__($e->getMessage()), $e);

TestCases:

\Magento\GraphQl\Customer\Quote\Customer\SetShippingAddressOnCartTest
 - testWithInvalidShippingAddressesInput

 \Magento\GraphQl\Customer\Quote\Customer\SetBillingAddressOnCartTest
 - testWithInvalidBillingAddressInput
 - testSetNotExistedBillingAddressId

Examples:

Magento\GraphQl\Customer
Magento\GraphQl\Quote\Customer

Guide:

Graphql Functional Testing
@TomashKhamlai TomashKhamlai self-assigned this Oct 3, 2019
@TomashKhamlai TomashKhamlai removed their assignment Oct 7, 2019
@atwixfirster atwixfirster self-assigned this Oct 9, 2019
@atwixfirster
Copy link
Contributor

atwixfirster commented Oct 9, 2019 •
edited
Loading

graphql-ce/app/code/Magento/QuoteGraphQl/Model/Cart/AssignShippingAddressToCart.php

Line 54 in e02dc94

throw new GraphQlInputException(__($e->getMessage()), $e);

done

graphql-ce/app/code/Magento/QuoteGraphQl/Model/Cart/AssignBillingAddressToCart.php

Line 54 in e02dc94

throw new GraphQlNoSuchEntityException(__($e->getMessage()), $e);

Already covered in dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer/SetBillingAddressOnCartTest.php::testSetNotExistedBillingAddressFromAddressBook()

graphql-ce/app/code/Magento/QuoteGraphQl/Model/Cart/AssignBillingAddressToCart.php

Line 56 in e02dc94

throw new GraphQlInputException(__($e->getMessage()), $e);

done

atwixfirster added a commit that referenced this issue Oct 9, 2019
@atwixfirster
#977: [Test coverage] Cover exceptions in AssignShippingAddressToCart…
26e3c20 
…, AssignBillingAddressToCart
@atwixfirster atwixfirster mentioned this issue Oct 10, 2019
Merged
4 tasks
atwixfirster added a commit that referenced this issue Oct 10, 2019
@atwixfirster
#977: [Test coverage] Cover exceptions in AssignShippingAddressToCart…
90557f9 
…, AssignBillingAddressToCart
@lenaorobei lenaorobei added this to the Release: 2.3.4 milestone Oct 14, 2019
atwixfirster added a commit that referenced this issue Oct 15, 2019
@atwixfirster
#977: [Test coverage] Cover exceptions in AssignShippingAddressToCart…
5bf67e5 
…, AssignBillingAddressToCart

Merge remote-tracking branch 'origin/2.3-develop' into 977-address-to-customer

# Conflicts:
#	dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer/SetBillingAddressOnCartTest.php
#	dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer/SetShippingAddressOnCartTest.php
lenaorobei added a commit that referenced this issue Oct 15, 2019
@lenaorobei
#977: [Test coverage] Cover exceptions in AssignShippingAddressToCart…
f49fe71 
…, AssignBillingAddressToCart
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Component: QuoteGraphQl good first issue Good for newcomers test-coverage
Projects
None yet
Milestone
Release: 2.3.4
Development

No branches or pull requests
3 participants
@TomashKhamlai @atwixfirster @lenaorobei