Skip to content
This repository was archived by the owner on Dec 19, 2019. It is now read-only.

#32 CMS block coverage #109

Merged
merged 7 commits into from
Jul 19, 2018

Conversation

roma-glushko
Copy link
Member

@roma-glushko roma-glushko commented Jun 30, 2018

Description

This PR enables CMS block API for GraphQL. Since it's merged, it would be possible to retrieve CMS blocks by identifier from GraphQL and the following information will be available:

  • CMS block identifier
  • CMS block title
  • CMS block content

Fixed Issues (if relevant)

  1. CMS block coverage #32: CMS block coverage

@roma-glushko roma-glushko self-assigned this Jun 30, 2018
@paliarush paliarush added requires-documentation requires-tests PRs which require GraphQL tests labels Jul 2, 2018
@nuzil
Copy link
Contributor

nuzil commented Jul 5, 2018

What about Status of Block? Can we extend to receive it also?

@roma-glushko
Copy link
Member Author

Hi @nuzil from the original requirements, the only enabled blocks can be retrieved by API. That's why status is not there.

Can you please suggest a case when we need this? So we will be able to discuss that all together

@nuzil
Copy link
Contributor

nuzil commented Jul 6, 2018

@roma-glushko in this case agree

@roma-glushko
Copy link
Member Author

@nuzil however, I got the question. For the first iteration, there is no way to adjust list of available data to retrieve, but it will in further steps I guess. This is really something that we need to have here and everywhere in GraphQl API

magento-engcom-team added a commit that referenced this pull request Jul 19, 2018
…with Export Type UI #109

 - Merge Pull Request magento-engcom/import-export-improvements#109 from dmanners/import-export-improvements:export-ui-fix
 - Merged commits:
   1. 64d0927
magento-engcom-team pushed a commit that referenced this pull request Jul 19, 2018
@naydav naydav changed the base branch from 2.3-develop to 31-cms-page-graphql-support July 19, 2018 10:13
Valeriy Nayda added 2 commits July 19, 2018 13:18
…support

# Conflicts:
#	app/code/Magento/CmsGraphQl/etc/module.xml
#	app/code/Magento/CmsGraphQl/etc/schema.graphqls
#	composer.lock
@naydav naydav merged commit dce6c11 into 31-cms-page-graphql-support Jul 19, 2018
@roma-glushko roma-glushko deleted the 32-cms-block-graphql-support branch July 23, 2018 17:27
magento-engcom-team pushed a commit that referenced this pull request May 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants