This repository was archived by the owner on Dec 19, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 153
#32 CMS block coverage #109
Merged
naydav
merged 7 commits into
31-cms-page-graphql-support
from
32-cms-block-graphql-support
Jul 19, 2018
Merged
#32 CMS block coverage #109
naydav
merged 7 commits into
31-cms-page-graphql-support
from
32-cms-block-graphql-support
Jul 19, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
What about Status of Block? Can we extend to receive it also? |
Hi @nuzil from the original requirements, the only enabled blocks can be retrieved by API. That's why status is not there. Can you please suggest a case when we need this? So we will be able to discuss that all together |
@roma-glushko in this case agree |
@nuzil however, I got the question. For the first iteration, there is no way to adjust list of available data to retrieve, but it will in further steps I guess. This is really something that we need to have here and everywhere in GraphQl API |
magento-engcom-team
added a commit
that referenced
this pull request
Jul 19, 2018
…with Export Type UI #109 - Merge Pull Request magento-engcom/import-export-improvements#109 from dmanners/import-export-improvements:export-ui-fix - Merged commits: 1. 64d0927
magento-engcom-team
pushed a commit
that referenced
this pull request
Jul 19, 2018
…with Export Type UI #109
…support # Conflicts: # app/code/Magento/CmsGraphQl/etc/module.xml # app/code/Magento/CmsGraphQl/etc/schema.graphqls # composer.lock
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
documentation-completed
Partner: Atwix
partners-contribution
requires-tests
PRs which require GraphQL tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables CMS block API for GraphQL. Since it's merged, it would be possible to retrieve CMS blocks by identifier from GraphQL and the following information will be available:
Fixed Issues (if relevant)