Skip to content
This repository was archived by the owner on Dec 19, 2019. It is now read-only.

[Checkout coverage] Place order concept #404

Merged
merged 10 commits into from
Apr 5, 2019

Conversation

rogyar
Copy link
Contributor

@rogyar rogyar commented Feb 26, 2019

Description (*)

This PR introduces a new mutation for placing an order. In order to place the order, the quote (cart) should contain a product as well as shipping/billing data assigned.

Fixed Issues (if relevant)

  1. [Checkout coverage] Place order #58 : [Checkout coverage] Place order
  2. [Place order] Place order mutation #295 : [Place order] Place order mutation

Manual testing scenarios (*)

  • Add a product to the shopping cart
  • Assign a shipping method and shipping address
  • Assign a payment method and billing address
  • Use the following mutation for placing the order:
mutation {
  placeOrder(input: {cart_id: "$maskedQuoteId"}) {
    order {
      order_id
    }
  }
}

rogyar added 2 commits March 3, 2019 15:40
# Conflicts:
#	app/code/Magento/QuoteGraphQl/etc/schema.graphqls
/**
* @magentoApiDataFixture Magento/Checkout/_files/quote_with_check_payment.php
*/
public function testPlaceOrderWithOutOfStockProduct()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it cover the situation here #437 Screenshot 2?
I believe it doesn't even if problem doesn't appear here. Actually I haven't tested "Place order concept" yet

@galaoleksandr
Copy link

Hello. I cannot place order on guest cart when shipping and payment methods are set on front.

@rogyar
Copy link
Contributor Author

rogyar commented Mar 26, 2019

Hi @galaoleksandr. Could you provide more information about the error message you are getting?
Also, could you describe, please, how you set payment method on the storefront without placing an order? Technically, when you click on a payment method radio button (on checkout page) the payment method is not being assigned to the quote. It's only being saved for user session on the storefront, so only customer's browser knows about the selected option:
image

In case of shipping method, it's being submitted to the backend once you go from shipping to payment step. The payment method submitted to the backend only after placing an order

Thank you

@galaoleksandr
Copy link

Hi @rogyar. I've tried to set payment method using GraphQl Playground. Now I get the next error:
image

@rogyar
Copy link
Contributor Author

rogyar commented Mar 27, 2019

Hi @galaoleksandr. Were you able to place an order (I see the label removed)? I can provide you with detailed steps.

Thank you

@magento-engcom-team magento-engcom-team merged commit d0c9cfa into 2.3-develop Apr 5, 2019
@ghost
Copy link

ghost commented Apr 5, 2019

Hi @rogyar, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants