GraphQl-439: Improve coverage for mutation addSimpleProductToCart or Cart contains a product after product got status Out of Stock #475

XxXgeoXxX · 2019-03-15T10:06:46Z

Description (*)

Issue #439

Manual testing scenarios (*)

Steps to reproduce (*)

Create Simple Product with
Name Simple Product
SKU: simple-product
Weight: 1
Price: 1
Qty: 1000
Create empty cart as a Guest or as Customer (GraphQL)
Add simple product to Cart (GraphQL)
Go to admin
Set Simple Product to be Out of Stock
Add Simple Product to Cart again (GraphQL) and get this error message

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

… a product after product got status Out of Stock

naydav · 2019-03-25T17:35:54Z

app/code/Magento/QuoteGraphQl/Model/Cart/AddProductsToCart.php

@@ -50,16 +50,16 @@ public function __construct(
     */
    public function execute(Quote $cart, array $cartItems): void
    {
-        foreach ($cartItems as $cartItemData) {


We can't move this logic after error checking.

Now it works as:

Perform adding products to cart

Check errors after the previous operation

changes were reverted

… a product after product got status Out of Stock

galaoleksandr · 2019-03-26T14:40:58Z

Cannot reproduce. Looks like it is already fixed.

…Cart contains a product after product got status Out of Stock

… a product after product got status Out of Stock. Merge conflicts

…Cart contains a product after product got status Out of Stock magento#475

lenaorobei · 2019-07-22T16:34:00Z

@XxXgeoXxX could you please address build failures.

… a product after product got status Out of Stock

… a product after product got status Out of Stock. Revert changes

… a product after product got status Out of Stock

…velop#439

… a product after product got status Out of Stock

lenaorobei · 2019-08-13T18:12:24Z

Please instead of new mutation please introduce new field.

lenaorobei · 2019-08-30T14:25:04Z

Closing this PR since no updates for more than 2 weeks. Please feel free to reopen if you want to continue working on this task. Thank you.

ghost · 2019-08-30T14:25:05Z

Hi @XxXgeoXxX, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

…velop#439

… a product after product got status Out of Stock magento#475

TomashKhamlai · 2019-09-24T15:52:41Z

Hello @XxXgeoXxX
Please merge the latest 2.3-develop. Schema is not loading on your PR. It can take a lot of time to find out why but merging locally fixed schema loading.

lenaorobei

Please use this approach https://github.com/magento/graphql-ce/pull/969/files#diff-0b2dca4fe975cc5dd9163cf736cd94daR134-R139

Signed-off-by: Tomash Khamlai <[email protected]>

TomashKhamlai · 2019-11-11T14:30:39Z

This PR introduces some improvements:
✔️ I was not able to place the order
❌ query cart shows that the product is in the cart

TomashKhamlai · 2019-11-11T14:31:46Z

@XxXgeoXxX, please read this comment #475 (review)

lenaorobei · 2019-12-03T21:52:21Z

Closing this PR due to inactivity. Please feel free to reopen if you are planning to continue working on it using proposed approach.

ghost · 2019-12-03T21:52:23Z

Hi @XxXgeoXxX, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Improve coverage for mutation addSimpleProductToCart or Cart contains…

76b25c2

… a product after product got status Out of Stock

magento-engcom-team added Partner: ISM eCompany partners-contribution labels Mar 15, 2019

XxXgeoXxX requested a review from naydav March 15, 2019 10:06

naydav suggested changes Mar 25, 2019

View reviewed changes

naydav added the Progress: needs update label Mar 25, 2019

Improve coverage for mutation addSimpleProductToCart or Cart contains…

9bb2932

… a product after product got status Out of Stock

naydav changed the title ~~Improve coverage for mutation addSimpleProductToCart or Cart contains a product after product got status Out of Stock~~ GraphQl-439: Improve coverage for mutation addSimpleProductToCart or Cart contains a product after product got status Out of Stock May 2, 2019

m2-community-project bot removed the Progress: needs update label Jul 10, 2019

XxXgeoXxX added 3 commits July 18, 2019 08:30

GraphQl-439: Improve coverage for mutation addSimpleProductToCart or …

6df7a81

…Cart contains a product after product got status Out of Stock

Improve coverage for mutation addSimpleProductToCart or Cart contains…

09c7897

… a product after product got status Out of Stock. Merge conflicts

GraphQl-439: Improve coverage for mutation addSimpleProductToCart or …

9fd75e9

…Cart contains a product after product got status Out of Stock magento#475

XxXgeoXxX and others added 11 commits July 29, 2019 09:13

Improve coverage for mutation addSimpleProductToCart or Cart contains…

f9a5784

… a product after product got status Out of Stock

Improve coverage for mutation addSimpleProductToCart or Cart contains…

58cfea5

… a product after product got status Out of Stock

Delete mypatch.patch

20f0d55

Delete Fix_the_special_price_expression.patch

9664559

Delete AddProductToCartTest.php

74ddb92

Improve coverage for mutation addSimpleProductToCart or Cart contains…

24b0339

… a product after product got status Out of Stock. Revert changes

Improve coverage for mutation addSimpleProductToCart or Cart contains…

5234a6d

… a product after product got status Out of Stock. Revert changes

Improve coverage for mutation addSimpleProductToCart or Cart contains…

0431ed2

… a product after product got status Out of Stock

Improve coverage for mutation addSimpleProductToCart or Cart contains…

198ba53

… a product after product got status Out of Stock

Merge branch '2.3-develop' of github.com:magento/magento2 into 2.3-de…

ce3af88

…velop#439

Improve coverage for mutation addSimpleProductToCart or Cart contains…

fcfc435

… a product after product got status Out of Stock

lenaorobei added the Progress: needs update label Aug 14, 2019

lenaorobei closed this Aug 30, 2019

XxXgeoXxX reopened this Sep 3, 2019

m2-community-project bot removed the Progress: needs update label Sep 3, 2019

XxXgeoXxX added 6 commits September 4, 2019 12:58

Merge branch '2.3-develop' of github.com:magento/magento2 into 2.3-de…

3f63007

…velop#439

Improve coverage for mutation addSimpleProductToCart or Cart contains…

1a5675b

… a product after product got status Out of Stock magento#475

Improve coverage for mutation addSimpleProductToCart or Cart contains…

66f42b0

… a product after product got status Out of Stock magento#475

Improve coverage for mutation addSimpleProductToCart or Cart contains…

304eae3

… a product after product got status Out of Stock magento#475

Improve coverage for mutation addSimpleProductToCart or Cart contains…

5f38def

… a product after product got status Out of Stock magento#475

Improve coverage for mutation addSimpleProductToCart or Cart contains…

d4419da

… a product after product got status Out of Stock magento#475

XxXgeoXxX requested a review from paliarush as a code owner September 5, 2019 05:28

XxXgeoXxX added 2 commits September 5, 2019 09:19

Improve coverage for mutation addSimpleProductToCart or Cart contains…

a98f4e2

… a product after product got status Out of Stock magento#475

Improve coverage for mutation addSimpleProductToCart or Cart contains…

24697ea

… a product after product got status Out of Stock magento#475

lenaorobei mentioned this pull request Sep 24, 2019

GraphQL cart error messages magento/architecture#291

Closed

lenaorobei added on hold Progress: on hold labels Sep 24, 2019

lenaorobei suggested changes Oct 23, 2019

View reviewed changes

m2-community-project bot assigned lenaorobei Oct 23, 2019

m2-community-project bot added Progress: changes requested and removed Progress: on hold labels Oct 23, 2019

lenaorobei added Progress: needs update and removed on hold labels Oct 23, 2019

Merge remote-tracking branch 'origin/2.3-develop' into 2.3-develop#439

abec8b4

Signed-off-by: Tomash Khamlai <[email protected]>

TomashKhamlai added Progress: needs update and removed Progress: needs update labels Nov 11, 2019

lenaorobei added this to the Release: 2.3.5 milestone Nov 18, 2019

lenaorobei closed this Dec 3, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

GraphQl-439: Improve coverage for mutation addSimpleProductToCart or Cart contains a product after product got status Out of Stock #475

GraphQl-439: Improve coverage for mutation addSimpleProductToCart or Cart contains a product after product got status Out of Stock #475

Uh oh!

XxXgeoXxX commented Mar 15, 2019

Uh oh!

naydav Mar 25, 2019

Uh oh!

XxXgeoXxX Mar 26, 2019

Uh oh!

galaoleksandr commented Mar 26, 2019

Uh oh!

lenaorobei commented Jul 22, 2019

Uh oh!

lenaorobei commented Aug 13, 2019

Uh oh!

lenaorobei commented Aug 30, 2019

Uh oh!

ghost commented Aug 30, 2019

Uh oh!

TomashKhamlai commented Sep 24, 2019

Uh oh!

lenaorobei left a comment

Uh oh!

TomashKhamlai commented Nov 11, 2019

Uh oh!

TomashKhamlai commented Nov 11, 2019

Uh oh!

lenaorobei commented Dec 3, 2019

Uh oh!

ghost commented Dec 3, 2019

Uh oh!

Uh oh!

GraphQl-439: Improve coverage for mutation addSimpleProductToCart or Cart contains a product after product got status Out of Stock #475

GraphQl-439: Improve coverage for mutation addSimpleProductToCart or Cart contains a product after product got status Out of Stock #475

Uh oh!

Conversation

XxXgeoXxX commented Mar 15, 2019

Description (*)

Manual testing scenarios (*)

Steps to reproduce (*)

Contribution checklist (*)

Uh oh!

naydav Mar 25, 2019

Choose a reason for hiding this comment

Uh oh!

XxXgeoXxX Mar 26, 2019

Choose a reason for hiding this comment

Uh oh!

galaoleksandr commented Mar 26, 2019

Uh oh!

lenaorobei commented Jul 22, 2019

Uh oh!

lenaorobei commented Aug 13, 2019

Uh oh!

lenaorobei commented Aug 30, 2019

Uh oh!

ghost commented Aug 30, 2019

Uh oh!

TomashKhamlai commented Sep 24, 2019

Uh oh!

lenaorobei left a comment

Choose a reason for hiding this comment

Uh oh!

TomashKhamlai commented Nov 11, 2019

Uh oh!

TomashKhamlai commented Nov 11, 2019

Uh oh!

lenaorobei commented Dec 3, 2019

Uh oh!

ghost commented Dec 3, 2019

Uh oh!

Uh oh!