This repository was archived by the owner on Dec 19, 2019. It is now read-only.
magento/graphql-ce#540: Replace deprecated fixture #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naydav
suggested changes
Mar 30, 2019
| * @magentoApiDataFixture Magento/Ups/_files/enable_ups_shipping_method.php | ||
| */ | ||
| public function testSetUpsShippingMethod() | ||
| { | ||
| $quote = $this->quoteFactory->create(); | ||
| $this->quoteResource->load($quote, 'test_order_1', 'reserved_order_id'); | ||
| $this->quoteResource->load($quote, 'test_quote', 'reserved_order_id'); |
There was a problem hiding this comment.
Please, replace quoteResource on \Magento\Quote\Model\QuoteIdToMaskedQuoteIdInterface
There was a problem hiding this comment.
Please, replace quoteResource on \Magento\Quote\Model\QuoteIdToMaskedQuoteIdInterface
done
There was a problem hiding this comment.
@naydav , all Ups methods have been added into test. Could you please review?
Thank you!
1. Add "Worldwide Expedited" to test
magento-engcom-team
pushed a commit
that referenced
this pull request
Apr 16, 2019
…e-for-SetUpsShippingMethodsOnCartTest
|
Hi @atwixfirster, thank you for your contribution! |
magento-engcom-team
pushed a commit
that referenced
this pull request
Apr 17, 2019
lenaorobei
deleted the
540-new-fixture-for-SetUpsShippingMethodsOnCartTest
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace deprecated
Magento/Checkout/_files/quote_with_address_saved.phpfixture with a new ones (from #539) inSetUpsShippingMethodsOnCartTestIssue: #540
Thank you!