-
Notifications
You must be signed in to change notification settings - Fork 153
GraphQl-661: Test coverage of FedEx shipping method #549
Conversation
Merge remote-tracking branch 'origin/2.3-develop' into 283-shipping-methods-FedEx
@naydav , this PR is ready for your review. Thank you!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@atwixfirster
As we talk early, need to introduce some mock object instead of 'real caller' object
Our tests should not depend on external system
The best way is creating preference in GraphQLTestModule and replace real object on our internal mock object
- code style fixes
Hi @lenaorobei, thank you for the review.
|
- added comment about selected shipping methods
Hi @naydav, thank you for the review.
|
Hi @naydav, thank you for the review. |
Hi @atwixfirster, thank you for your contribution! |
Issue: #661
Description (*)
To test FedEx on-line shipping carrier then you should create a sandbox account and configure FedEx shipping method on back-end side:
Proposed solution (*)
Move all sandbox settings to
dev/tests/api-functional/config/config-global.php
config file (this file under git ignore so we can hide our sandbox settings from the 3rd eyes):