Skip to content
This repository was archived by the owner on Dec 19, 2019. It is now read-only.

GraphQl-661: Test coverage of FedEx shipping method #549

Merged
merged 10 commits into from
Jun 19, 2019

Conversation

atwixfirster
Copy link
Contributor

@atwixfirster atwixfirster commented Mar 29, 2019

Issue: #661

Description (*)

To test FedEx on-line shipping carrier then you should create a sandbox account and configure FedEx shipping method on back-end side:

fedex

Proposed solution (*)

Move all sandbox settings to dev/tests/api-functional/config/config-global.php config file (this file under git ignore so we can hide our sandbox settings from the 3rd eyes):

<?php
/**
 * Copyright © Magento, Inc. All rights reserved.
 * See COPYING.txt for license details.
 */

return [
    'carriers' => [
        'usps' => [
            'userid' => '0:3:xxxxxxx1==',
            'password' => '0:3:xxxxxxx2==',
        ],
        'fedex' => [
            'account' => '0:3:yyyyyyyy0==',
            'meter_number' => '0:3:yyyyyyyy1==',
            'key' => '0:3:yyyyyyyy2=',
            'password' => '0:3:yyyyyyyy3=',
            'production_webservices_url' => 'https://wsbeta.fedex.com:443/web-services',
        ],
    ]
];

@atwixfirster
Copy link
Contributor Author

@naydav , this PR is ready for your review.

Thank you!!

@naydav naydav changed the title 283 - [Shipping methods] Support of FedEx shipping method GraphQl-661: Test coverage of FedEx shipping method May 2, 2019
Copy link
Contributor

@naydav naydav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atwixfirster
As we talk early, need to introduce some mock object instead of 'real caller' object
Our tests should not depend on external system

The best way is creating preference in GraphQLTestModule and replace real object on our internal mock object

@lenaorobei lenaorobei requested a review from naydav June 13, 2019 16:26
@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-5285 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

- added comment about selected shipping methods
@magento-engcom-team
Copy link
Contributor

Hi @naydav, thank you for the review.
ENGCOM-5285 has been created to process this Pull Request
✳️ @naydav, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@magento-engcom-team
Copy link
Contributor

Hi @naydav, thank you for the review.
ENGCOM-5285 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit d12b253 into 2.3-develop Jun 19, 2019
@ghost
Copy link

ghost commented Jun 19, 2019

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants