Skip to content
This repository was archived by the owner on Dec 19, 2019. It is now read-only.

GraphQl-509 save address to address book #690

Closed
wants to merge 7 commits into from
Closed

GraphQl-509 save address to address book #690

wants to merge 7 commits into from

Conversation

VitaliyBoyko
Copy link
Contributor

Description (*)

Provided support of saving an address in an address book on quote address mutations.

Fixed Issues (if relevant)

  1. save_in_address_book has no impact on Address Book #509: save_in_address_book has no impact on Address Book

@VitaliyBoyko VitaliyBoyko changed the title Graph ql 509 save address to address book GraphQl-509 save address to address book May 8, 2019
Merge branches '2.3-develop' and 'graphQl-509-save-address-to-address…
46ba657 
…-book' of github.com:magento/graphql-ce into graphQl-509-save-address-to-address-book
@lenaorobei
Copy link
Contributor

@VitaliyBoyko please address small issues in static build. testCodeStyle failure is related to PHPDoc blocks and testCodeMess to coupling between objects and cyclomatic complexity. Thank you.

lenaorobei
lenaorobei reviewed Jun 10, 2019
View reviewed changes
app/code/Magento/QuoteGraphQl/Model/Cart/SetBillingAddressOnCart.php Outdated
$this->assignBillingAddressToCart->execute($cart, $billingAddress, $useForShipping);

if (!empty($addressInput) && !empty($addressInput['save_in_address_book']) && 0 !== $customerId) {
Copy link
Contributor

@lenaorobei lenaorobei Jun 10, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (!empty($addressInput) && !empty($addressInput['save_in_address_book']) && 0 !== $customerId) {
if (0 !== $customerId && !empty($addressInput['save_in_address_book']))

lenaorobei
lenaorobei reviewed Jun 10, 2019
View reviewed changes
app/code/Magento/QuoteGraphQl/Model/Cart/SetShippingAddressesOnCart.php Outdated
$this->assignShippingAddressToCart->execute($cart, $shippingAddress);

if (!empty($addressInput) && !empty($addressInput['save_in_address_book']) && 0 !== $customerId) {
Copy link
Contributor

@lenaorobei lenaorobei Jun 10, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (!empty($addressInput) && !empty($addressInput['save_in_address_book']) && 0 !== $customerId) {
if (0 !== $customerId && !empty($addressInput['save_in_address_book']))

@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-5243 has been created to process this Pull Request

@naydav
Copy link
Contributor

naydav commented Jun 14, 2019

@VitaliyBoyko
Do you have some updates on this ticket? Just mainline was merged without any progress.
Thanks

@naydav
Copy link
Contributor

naydav commented Jun 25, 2019

Hello @VitaliyBoyko ,
The ticket was unassigned due to inactivity. Also, during this time, the mainline has changed very much and the code in the PR becomes outdated.
Please assign it again if you wish to continue.
Thanks!

@naydav naydav closed this Jun 25, 2019
@ghost
Copy link

ghost commented Jun 25, 2019

Hi @VitaliyBoyko, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@okorshenko okorshenko deleted the graphQl-509-save-address-to-address-book branch December 18, 2019 22:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lenaorobei lenaorobei lenaorobei approved these changes

Assignees

@naydav naydav

@lenaorobei lenaorobei

@VitaliyBoyko VitaliyBoyko

Labels
Component: QuoteGraphQl Partner: Atwix partners-contribution Progress: needs update Release Line: 2.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@VitaliyBoyko @lenaorobei @magento-engcom-team @naydav @TomashKhamlai