Skip to content
This repository was archived by the owner on Dec 19, 2019. It is now read-only.

Fedex Soap Mock #755

Merged
merged 1 commit into from
Jul 11, 2019
Merged

Fedex Soap Mock #755

merged 1 commit into from
Jul 11, 2019

Conversation

pmclain
Copy link
Contributor

@pmclain pmclain commented Jun 26, 2019

Description (*)

Creates a mock soap client for fetching rates during test execution.

Fixed Issues (if relevant)

  1. Introduce mock for Fedex shipping testing #740

Manual testing scenarios (*)

  1. cd dev/tests/api-functional
  2. ../../../vendor/bin/phpunit testsuite/Magento/GraphQl/FedEx/SetFedExShippingMethodsOnCartTest.php

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Creates a mock soap client for fetching rates during test execution.

Fixes magento#740
@magento-engcom-team
Copy link
Contributor

Hi @naydav, thank you for the review.
ENGCOM-5361 has been created to process this Pull Request
✳️ @naydav, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@ghost
Copy link

ghost commented Jul 11, 2019

Hi @pmclain, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants