This repository was archived by the owner on Dec 19, 2019. It is now read-only.
graphQl-784: added validation for the lowercase country id in the quote address #790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@magento run all tests |
lenaorobei
reviewed
Jul 25, 2019
lenaorobei
reviewed
Jul 25, 2019
...ests/api-functional/testsuite/Magento/GraphQl/Quote/Customer/SetBillingAddressOnCartTest.php
Outdated
Show resolved
Hide resolved
lenaorobei
approved these changes
Jul 25, 2019
|
Hi @lenaorobei, thank you for the review.
|
m2-community-project
bot
added
Progress: approved
Progress: ready for delivery
and removed
Progress: review
Progress: approved
labels
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for delivery
labels
|
Hi @VitaliyBoyko, thank you for your contribution! |
magento-engcom-team
pushed a commit
that referenced
this pull request
Jul 30, 2019
…id in the quote address #790
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Added validation with the message "Country Code cannot contain lowercase characters."
Fixed Issues (if relevant)