This repository was archived by the owner on Dec 19, 2019. It is now read-only.
Mark config fixtures as deprecated #800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenaorobei
suggested changes
Aug 1, 2019
There was a problem hiding this comment.
Please refer to the original issue.
AC is following:
- Fixtures with reference Add support for '@magentoConfigFixture' annotation on API-functional tests #167 to are marked as deprecated (TODOs should be removed)
- Explanatory comment about @magentoConfigFixture annotation is added (after the deprecated tag).
So it should look like@deprecated use @magentoConfigFixture instead. - No tests are using deprecated fixtures.
lenaorobei
suggested changes
Aug 5, 2019
| @@ -3,6 +3,12 @@ | |||
| * Copyright © Magento, Inc. All rights reserved. | |||
There was a problem hiding this comment.
Found the use of this file in \Magento\GraphQl\AuthorizenetAcceptjs\Customer\SetPaymentMethodTest::testPlaceOrder. It needs to be replaced with @magentoConfigFixture.
| * @magentoConfigFixture default_store payment/checkmo/active 0 | ||
| * @magentoConfigFixture default_store payment/free/active 0 | ||
| * | ||
| */ | ||
| // TODO: Should be removed in scope of https://github.com/magento/graphql-ce/issues/167 |
There was a problem hiding this comment.
All TODOs should be removed.
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
lenaorobei
approved these changes
Aug 6, 2019
|
Hi @lenaorobei, thank you for the review.
|
|
Hi @XxXgeoXxX, thank you for your contribution! |
magento-engcom-team
pushed a commit
that referenced
this pull request
Aug 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Original issue #794
Contribution checklist (*)