graphQl-509: save_in_address_book has no impact on Address Book

[kisroman]

#509

[lenaorobei]

Please address static build failure.

[lenaorobei]

Please throw an exception for guests.

[kisroman]

Seems like we don't need it in this place. We have this exception in case $customerAddressId !== null

[lenaorobei]

I believe we can move this code to the top of the method.

if (false === $context->getExtensionAttributes()->getIsCustomer()) {
    throw new GraphQlAuthorizationException(__('The current customer isn\'t authorized.'));
}

This will simplify the complexity.
And if value is expected to be boolean, please use strict comparison.

(bool)$addressInput['save_in_address_book'] === false

[kisroman]

@lenaorobei, Seems like we can't as with if (null === $customerAddressId) we are creating billing address for guest.
Array may don't have "save_in_address_book". So we will need double check: for isset and (bool)$addressInput['save_in_address_book'] === true. Can't we just leave only check for empty()?

[lenaorobei]

Because of PHP type casting please use isset + === true.

[kisroman]

Done

[lenaorobei]

Please consider refactoring createBillingAddress and createShippingAddress methods.

[magento-engcom-team]

Hi @lenaorobei, thank you for the review.
ENGCOM-6056 has been created to process this Pull Request

[ghost]

Hi @kisroman, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.