Skip to content
This repository was archived by the owner on Dec 19, 2019. It is now read-only.

Add Merge Cart Mutation #950

Merged
merged 2 commits into from
Nov 5, 2019
Merged

Conversation

pmclain
Copy link
Contributor

@pmclain pmclain commented Sep 21, 2019

Description (*)

Add mutation for merging carts.

Guest Use Cases:

  • Merge two guest carts

Customer Use Cases:

  • Merge customer cart with guest cart
  • Merge customer cart with inactive customer cart

Fixed Issues

  1. [Checkout] Implement mergeCarts #905

Manual testing scenarios (*)

  1. Create two carts
  2. Add products to each cart
mutation {
  mergeCarts(input: {
    first_cart_id: "{$firstMaskedId}"
    second_cart_id: "{$secondMaskedId}"
  })
}

Expected Result
Cart contents are merged. A new masked cart id is returned and the previous masked ids return a not found error.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

 * Merge two guest carts

 * Merge customer cart with guest cart
 * Merge customer cart with inactive customer cart

Fixes magento#905
@lenaorobei
Copy link
Contributor

Need to move this PR to on hold until we will finalize product requirements with @nrkapoor
magento/architecture#288

@lenaorobei
Copy link
Contributor

Sorry to say that but I need to close this PR due to requirement changes. The new flow we'll be working on:
Screen Shot 2019-10-14 at 9 25 11 AM

@lenaorobei lenaorobei closed this Oct 14, 2019
@ghost
Copy link

ghost commented Oct 14, 2019

Hi @pmclain, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@lenaorobei lenaorobei reopened this Oct 25, 2019
@magento-engcom-team magento-engcom-team merged commit 6a61d04 into magento:2.3-develop Nov 5, 2019
@ghost
Copy link

ghost commented Nov 5, 2019

Hi @pmclain, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants