You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Run against Magento2 codebase. vendor/bin/phpcs --standard=Magento2 app/code lib/internal/ --sniffs=Magento2.Exceptions.Namespace -s
Expected result
No false-positive findings.
Actual result
>60 false-positive findings detected. Example:
FILE: app/code/Magento/OfflineShipping/Model/ResourceModel/Carrier/Tablerate/CSV/ColumnResolver.php
--------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------
60 | WARNING | Namespace for ColumnNotFoundException class is not specified. (Magento2.Exceptions.Namespace.NotFoundNamespace)
65 | WARNING | Namespace for ColumnNotFoundException class is not specified. (Magento2.Exceptions.Namespace.NotFoundNamespace)
--------------------------------------------------------------------------------------------------------------------------------------------------
Solution
Remove this rule from Coding Standard in favor of implementation that can capture class existence (PHPStan).
The text was updated successfully, but these errors were encountered:
* develop:
REPO-66: [EQP][Sniffs Consolidation] Deliver Magento Coding Standard to magento2ce
Fixed name in ruleset
Remove multiple empty line
Fix line length sniff when using translations
Made InsecureFunctionSniff in line with UnsecureFunctionsUsageTest
Removed CyclomaticComplexity
Removed DateTime sniff
Removed DateTime sniff
Removed DateTime sniff
magento#67: Remove Magento2.Exceptions.Namespace
Removed ObjectInstantiation sniff
XssTemplateSniff does not detect some use cases
[Enhancement] DiscouragedFunction rule improvement
[Enhancement] DiscouragedFunction rule improvement
Namespace conflict with core rules
Removed unstable Annotation sniffs
Preconditions
Magento2 CodingStandard is installed.
Steps to reproduce
Run against Magento2 codebase.
vendor/bin/phpcs --standard=Magento2 app/code lib/internal/ --sniffs=Magento2.Exceptions.Namespace -s
Expected result
No false-positive findings.
Actual result
>60
false-positive findings detected. Example:Solution
Remove this rule from Coding Standard in favor of implementation that can capture class existence (PHPStan).
The text was updated successfully, but these errors were encountered: