Skip to content

#147: Fix for files that contain phtml #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

larsroettig
Copy link
Member

see #147

@lenaorobei
Copy link
Contributor

I dont think it is the proper way to fix this issue. If it is PHPCS bug, we need to create one and add a reference to our issue.

@larsroettig
Copy link
Member Author

larsroettig commented Oct 15, 2019

Hi @lenaorobei,
magento-coding-standard/vendor/squizlabs/php_codesniffer/src/Files/File.php:469 the regex what he uses is the problem.

Soultion:
squizlabs/PHP_CodeSniffer#2486

Copy link
Contributor

@lenaorobei lenaorobei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix all exclude-pattern and include-pattern occurrences in the ruleset.

@lenaorobei lenaorobei added the needs update PR or issue needs update from the author label Oct 30, 2019
@lenaorobei lenaorobei deleted the 147-error-phtml branch August 18, 2020 14:49
magento-devops-reposync-svc pushed a commit that referenced this pull request Feb 9, 2022
…nto-coding-standard-368

[Imported] AC-2224: Remove incorrect and outdated rules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants