Added sniff for deprecated model methods. #187 #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

lenaorobei merged 6 commits into magento:develop from milindsingh:deprecated-methods

Aug 17, 2020

Member

milindsingh commented May 23, 2020

Added sniff for #187 to discourage the use of Resource class from Model class.

Trigger Methods:

getResource()->load($object)
getResource()->save($object)
getResource()->delete($object)

Message: Possible use of the deprecated model method 'getResource()' to 'save' the data detected.

magento-engcom-team added community-insider-contribution Community Insider: Cedcommerce labels

milindsingh marked this pull request as ready for review

May 23, 2020 18:42


          Added sniff for deprecated model methods. #187

1d380aa

lenaorobei reviewed

View reviewed changes

Magento2/Sniffs/Methods/DeprecatedModelMethodSniff.php Outdated Show resolved Hide resolved

m2-community-project bot assigned lenaorobei

m2-community-project bot added the Progress: review label

lenaorobei reviewed

View reviewed changes

Magento2/Sniffs/Methods/DeprecatedModelMethodSniff.php Outdated Show resolved Hide resolved

lenaorobei reviewed

View reviewed changes

Magento2/Sniffs/Methods/DeprecatedModelMethodSniff.php Outdated Show resolved Hide resolved

lenaorobei reviewed

View reviewed changes

Magento2/Tests/Methods/DeprecatedModelMethodUnitTest.inc Outdated Show resolved Hide resolved

lenaorobei reviewed

View reviewed changes

Magento2/Tests/Methods/DeprecatedModelMethodUnitTest.inc Outdated Show resolved Hide resolved

lenaorobei requested changes

View reviewed changes

Contributor

lenaorobei left a comment

Please address review comments.


          code review fixes

a5b3723

m2-community-project bot assigned ihor-sviziev

lenaorobei reviewed

View reviewed changes

Magento2/Tests/Methods/DeprecatedModelMethodUnitTest.inc Show resolved Hide resolved

ihor-sviziev added 2 commits

August 17, 2020 15:45


          Added sniff for deprecated model methods

eb17063

Add few negative cases


          Merge branch 'develop' into deprecated-methods

8304fab

Member Author

milindsingh commented Aug 17, 2020 •

edited

Loading

Thanks @ihor-sviziev
@lenaorobei I think its good to merge now.

Also, Is there any way to change labels to Partner: Born Group partners-contribution ?

ihor-sviziev previously approved these changes

View reviewed changes

Contributor

lenaorobei commented Aug 17, 2020

Great! Thanks @ihor-sviziev. Let me run this test again Magento codebase and make sure it does not produce false positive findings.

lenaorobei added 2 commits

August 17, 2020 14:43


          Merge branch 'develop' into deprecated-methods

b7fd1ed


          #187: Added sniff for deprecated model methods

902b134

- minor fixes

lenaorobei dismissed ihor-sviziev’s stale review via

902b134

August 17, 2020 20:10

lenaorobei approved these changes

View reviewed changes

lenaorobei merged commit edca711 into magento:develop

m2-community-project bot added Progress: done and removed Progress: review labels

magento-devops-reposync-svc pushed a commit that referenced this pull request


          Merge pull request #189 from magento-commerce/version-25

7be8305

Bump to version 25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Community Insider: Cedcommerce community-insider-contribution Progress: done