Skip to content

AC-2224: Remove incorrect and outdated rules #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 9, 2022
Merged

AC-2224: Remove incorrect and outdated rules #368

merged 4 commits into from
Feb 9, 2022

Conversation

loginesta
Copy link
Contributor

@loginesta loginesta commented Feb 9, 2022 •
edited by sivaschenko
Loading

https://jira.corp.magento.com/browse/AC-2224 Remove incorrect and outdated rules

Resolves #351

Rules (or checks that are parts of rules) that should be removed from magento-coding-standard:

  • Generic.Functions.CallTimePassByReference.NotAllowed (outdated)
  • Magento2.Legacy.PhtmlTemplate.ThisUsageObsolete (duplicate)
  • Magento2.Legacy.PhtmlTemplate.FoundJQueryUI (incorrect False positive Magento2.Legacy.PhtmlTemplate #351)
  • Magento2.Legacy.PhtmlTemplate.FoundXMagentoInit (incorrect False positive Magento2.Legacy.PhtmlTemplate #351)
  • Magento2.Legacy.PhtmlTemplate.FoundDataMageInit (incorrect False positive Magento2.Legacy.PhtmlTemplate #351)
  • PHPCompatibility.AbstractPrivateMethods (PHP 7.4 or lower)
  • PHPCompatibility.NewAttributes (PHP 7.4 or lower)
  • PHPCompatibility.NewInterpolatedStringDereferencing (PHP 7.4 or lower)
  • PHPCompatibility.NewMagicClassConstant (PHP 7.4 or lower)
  • PHPCompatibility.NewMagicConstantDereferencing (PHP 7.4 or lower)
  • PHPCompatibility.NewNestedStaticAccess (PHP 7.4 or lower)
  • PHPCompatibility.NewNonCapturingCatch (PHP 7.4 or lower)
  • PHPCompatibility.NewTrailingComma (PHP 7.4 or lower)

@loginesta loginesta marked this pull request as ready for review February 9, 2022 11:39
@sivaschenko
Copy link
Member

@magento import pr to magento-commerce/magento-coding-standard

@m2-github-services
Copy link
Contributor

@sivaschenko the Pull Request is successfully imported.

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit e88b344 into magento:develop Feb 9, 2022
@loginesta loginesta deleted the AC-2224 branch February 9, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko sivaschenko approved these changes

@svera svera Awaiting requested review from svera

@eliseacornejo eliseacornejo Awaiting requested review from eliseacornejo

Assignees

@sivaschenko sivaschenko

Labels
Progress: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positive Magento2.Legacy.PhtmlTemplate
4 participants
@loginesta @sivaschenko @m2-github-services @magento-devops-reposync-svc