AC-2222: [UCT Autofixing] PHPCompatibility.ForbiddenFinalPrivateMethods #373
+62
−108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sivaschenko
reviewed
Feb 11, 2022
Magento2/Tests/PHPCompatibility/ForbiddenFinalPrivateMethodsUnitTest.inc
Show resolved
Hide resolved
m2-community-project
bot
added
Progress: review
and removed
Progress: ready for review
labels
sivaschenko
approved these changes
Feb 11, 2022
|
@magento import pr to magento-commerce/magento-coding-standard |
|
@sivaschenko the Pull Request is successfully imported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code will autofix occurrences of
final privatemethods which actually make no sense.Note that original test code was customised for PHPCompatibility and didn't support autofix checking, so I had to adapt it to PHPCS unit tests-style. Also, warning was only issued if code had to be compatible with PHP 8.