Skip to content

Resolve issues with regex include and exclude patterns in Magento 2 ruleset.xml #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Resolve issues with regex include and exclude patterns in Magento 2 ruleset.xml #486

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6682757
Fixed include-patterns for Windows
gwharton Aug 29, 2024
e4f12a7
Fixed include-patterns for Windows
gwharton Aug 29, 2024
f258e53
Fixed include-patterns for Windows
gwharton Aug 29, 2024
1b283eb
Fixed include-patterns for Windows
gwharton Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions Magento2/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@
<rule ref="Magento2.Legacy.Layout">
<severity>10</severity>
<type>error</type>
<include-pattern>*/view/(adminhtml|frontend|base)/*\/.xml</include-pattern>
<include-pattern>*/view/(adminhtml|frontend|base)/*/*.xml</include-pattern>
</rule>
<rule ref="Magento2.Legacy.RestrictedCode">
<severity>10</severity>
Expand All @@ -165,10 +165,10 @@
<exclude-pattern>*\.js$</exclude-pattern>
</rule>
<rule ref="Magento2.Legacy.ClassReferencesInConfigurationFiles">
<include-pattern>*\/etc/*.xml$</include-pattern>
<exclude-pattern>*\/etc/wsdl.xml$</exclude-pattern>
<exclude-pattern>*\/etc/wsdl2.xml$</exclude-pattern>
<exclude-pattern>*\/etc/wsi.xml$</exclude-pattern>
<include-pattern>*/etc/*.xml$</include-pattern>
<exclude-pattern>*/etc/wsdl.xml$</exclude-pattern>
<exclude-pattern>*/etc/wsdl2.xml$</exclude-pattern>
<exclude-pattern>*/etc/wsi.xml$</exclude-pattern>
<severity>10</severity>
<type>error</type>
</rule>
Expand Down Expand Up @@ -212,7 +212,7 @@
<exclude-pattern>*\.xml$</exclude-pattern>
</rule>
<rule ref="Magento2.Html.HtmlBinding">
<include-pattern>*\/.phtml$</include-pattern>
<include-pattern>*\.phtml$</include-pattern>
<severity>9</severity>
<type>warning</type>
<exclude-pattern>*\.xml$</exclude-pattern>
Expand Down Expand Up @@ -307,12 +307,12 @@
<type>warning</type>
</rule>
<rule ref="Magento2.Legacy.ModuleXML">
<include-pattern>*\/module.xml$</include-pattern>
<include-pattern>*/module.xml$</include-pattern>
<severity>8</severity>
<type>warning</type>
</rule>
<rule ref="Magento2.Legacy.DiConfig">
<include-pattern>*\/di.xml$</include-pattern>
<include-pattern>*/di.xml$</include-pattern>
<severity>8</severity>
<type>warning</type>
</rule>
Expand All @@ -322,7 +322,7 @@
<exclude-pattern>*\.xml$</exclude-pattern>
</rule>
<rule ref="Magento2.Legacy.WidgetXML">
<include-pattern>*\/widget.xml$</include-pattern>
<include-pattern>*/widget.xml$</include-pattern>
<severity>8</severity>
<type>warning</type>
</rule>
Expand Down
Loading