[Arrows] MC-21844: SVC false-positive: short names & FQCN in DockBlock #51
Conversation
|
@roribio could you please take a look at our PR |
zakdma
changed the title
| { | ||
| $return = parent::enterNode($node); | ||
|
|
||
| if ($node instanceof ClassMethod) { |
There was a problem hiding this comment.
Property, ClassConst also may have annotation that describes a type. For Magento this is a less important cases and may be addressed in separate PRs.
src/Visitor/NameResolver.php
Outdated
| if ($docNode) { | ||
| $result = []; | ||
| /** @var PhpDocTagNode[] $paramTags */ | ||
| $paramTags = $docNode->getTagsByName('@param'); |
There was a problem hiding this comment.
Note: getParamTagValues returns node with more suitable API
src/Visitor/NameResolver.php
Outdated
| } | ||
|
|
||
| /** @var PhpDocTagNode[] $returnTags */ | ||
| $returnTags = $docNode->getTagsByName('@return'); |
There was a problem hiding this comment.
Note: getReturnTagValues returns node with more suitable API
| $resolvedType = $this->resolveType($normalizedType); | ||
| $result[] = $resolvedType; | ||
| } | ||
| } else { |
There was a problem hiding this comment.
Note: Please ensure that PHPStan\PhpDocParser\Ast\Type\NullableTypeNode should not be handled as special case (equals to union null|type)
There was a problem hiding this comment.
?type is parsed as NullableType
type|null is parsed as UnionType
So I handle only UnionType case as list of FullyQualified types because there can be also annotation like that
Product|int|null
|
@vkublytskyi all fixed except constants and variable types parsing |
roribio
requested review from
vkublytskyi
and removed request for
vkublytskyi
Revert "Add enum to visitor"
Scope
Bug - P1
Bamboo CI builds
Related Pull Requests
Created by : @zakdma