Skip to content

update dependencies #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2021
Merged

update dependencies #814

merged 1 commit into from
Feb 10, 2021

Conversation

sergeynezbritskiy
Copy link
Contributor

@sergeynezbritskiy sergeynezbritskiy commented Jan 24, 2021

Description

Update dependencies in order to unlock PHP8 compatible packages
see magento/magento2#31777

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@sergeynezbritskiy
Copy link
Contributor Author

Additionally I had to update the version constraint for sebastian/phpcpd module from ~5.0.0 to ~6.0.0.
Version 5 of phpcd fails with xdebug 3 with the next error

      COPY PASTE DETECTOR
===============================
PHP Fatal error:  Uncaught Error: Call to undefined function xdebug_disable() in /home/runner/work/magento2-functional-testing-framework/magento2-functional-testing-framework/vendor/sebastian/phpcpd/src/CLI/Application.php:99
Stack trace:
#0 /home/runner/work/magento2-functional-testing-framework/magento2-functional-testing-framework/vendor/sebastian/phpcpd/src/CLI/Application.php(45): SebastianBergmann\PHPCPD\CLI\Application->disableXdebug()
#1 /home/runner/work/magento2-functional-testing-framework/magento2-functional-testing-framework/vendor/symfony/console/Application.php(149): SebastianBergmann\PHPCPD\CLI\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#2 /home/runner/work/magento2-functional-testing-framework/magento2-functional-testing-framework/vendor/sebastian/phpcpd/phpcpd(51): Symfony\Component\Console\Application->run()```

@jilu1
Copy link
Contributor

jilu1 commented Jan 25, 2021

@sergeynezbritskiy Thanks for your pull request!
We have an internal ticket for a similar issue. Let me check if this can make into next release.

@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework

@magento-engcom-team
Copy link

@jilu1 the pull request successfully imported.

@jilu1
Copy link
Contributor

jilu1 commented Jan 26, 2021

@sergeynezbritskiy
I tried to upgrade both ramsey/uuid and sebastian/phpcpd and got some different results. In my case I don't need to update dependencies like aws/aws-sdk-php.

Did your run composer update for all or only on selected dependencies?

@jilu1
Copy link
Contributor

jilu1 commented Jan 29, 2021

@sergeynezbritskiy
We will go conservative with upgrading only on necessities. We will include upgrade ramsey/uuid as part of our internal ticket https://jira.corp.magento.com/browse/MQE-2436 and https://jira.corp.magento.com/browse/MQE-2490. The change will be included in next release.

@jilu1 jilu1 closed this Jan 29, 2021
@sergeynezbritskiy
Copy link
Contributor Author

@jilu1 ok, thanks
can you give an ETA, when those changes will be released ?

@sergeynezbritskiy
Copy link
Contributor Author

also, can we review an option to remove composer.lock file at all from the project ?
nowadays mftf basic installation way is using composer, and installing as a standalone app is desired when "develop for or contribute to MFTF" https://devdocs.magento.com/mftf/docs/getting-started.html#set-up-a-standalone-mftf.
So probably for Magento2 project it would be better do not lock any dependencies within mftf, but instead give a chance to composer to calculate dependencies for Magento2 itself
E.g. currently there is one more similar issue in magento 2 repo magento/magento2#31177, which also would need to update some packages, which are currently locked by mftf's composer.lock file.
So the scenario for such packages would be always "update dependency in mftf -> release updates -> update mftf version in magento2 -> finally update locked dependency"

@sergeynezbritskiy
Copy link
Contributor Author

@sergeynezbritskiy
I tried to upgrade both ramsey/uuid and sebastian/phpcpd and got some different results. In my case I don't need to update dependencies like aws/aws-sdk-php.

Did your run composer update for all or only on selected dependencies?

@jilu1 I've ran composer update for all packages, because found some other issues (e.g. magento/magento2#31177) which I can't proceed with due to locking the versions of some packages in mftf's composer.lock file, so I desided to update all packages at once

@okolesnyk okolesnyk reopened this Feb 10, 2021
@mmansoor-magento mmansoor-magento merged commit 629a5f6 into magento:develop Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants