MAGETWO-49586: [GitHub] Fix Web API error masking in production mode #2371

Author: Oleksii Korshenko

lib/internal/Magento/Framework/Reflection/TypeProcessor.php

@@ -421,12 +421,6 @@ public function isArrayType($type)
 
     /**
      * Get item type of the array.
-     * Example:
-     * <pre>
-     *  ComplexType[] => ComplexType
-     *  string[] => string
-     *  int[] => integer
-     * </pre>
      *
      * @param string $arrayType
      * @return string

lib/internal/Magento/Framework/Webapi/ErrorProcessor.php

@@ -190,9 +190,10 @@ public function renderException(\Exception $exception, $httpCode = self::DEFAULT
     protected function _critical(\Exception $exception)
     {
         $reportId = uniqid("webapi-");
-
-        $this->_logger->critical(new WebapiException\WebapiExceptionReport($reportId, $exception));
-
+        $message = "Report ID: {$reportId}; Message: {$exception->getMessage()}";
+        $code = $exception->getCode();
+        $exception = new \Exception($message, $code, $exception);
+        $this->_logger->critical($exception);
         return $reportId;
     }
 

lib/internal/Magento/Framework/Webapi/Exception/WebapiExceptionReport.php

@@ -234,10 +234,13 @@ public function testCriticalExceptionStackTrace()
 
         $this->_loggerMock->expects($this->once())
             ->method('critical')
-            ->will($this->returnCallback(function(\Exception $loggedException) use($thrownException) {
-                $this->assertSame($thrownException, $loggedException->getPrevious());
-            }));
-
+            ->will(
+                $this->returnCallback(
+                    function (\Exception $loggedException) use ($thrownException) {
+                        $this->assertSame($thrownException, $loggedException->getPrevious());
+                    }
+                )
+            );
         $this->_errorProcessor->maskException($thrownException);
     }