Fix Web API error masking in production mode #2371
Merged
+53
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I have changed exception masking for Web API. Current implementation hide Stack trace and may cause fatal errors for custom exception types because it tries to reinstantiate exception with different messages. In my proposed implementation I'm wrapping original exception into
WebapiExceptionReport
which carryreportId
in the property and original exception asprevious
exception.Ways to reproduce:
A. Losing stack trace
Expected result
I can see WebAPI report ID in the API response and exception stack trace in the log file.
Actual result
I can see WebAPI report ID in the API response but exception stack trace always refer to
crtitical
method call:B. Fatal error during exception creation
Expected result
We should see exception message in the log
Actual result
Fatal error: Argument 1 passed to ...::__construct() must be of the type array, string given