MAGETWO-70591: magento/magento2:#6175 Fixed Unable to generate unsecure URL if current URL is secure #10188

 - added integration tests

Author: Oleksii Korshenko

dev/tests/integration/testsuite/Magento/Framework/UrlTest.php

@@ -6,6 +6,7 @@
 namespace Magento\Framework;
 
 use Zend\Stdlib\Parameters;
+use Magento\TestFramework\Helper\Bootstrap;
 
 class UrlTest extends \PHPUnit_Framework_TestCase
 {
@@ -16,7 +17,7 @@ class UrlTest extends \PHPUnit_Framework_TestCase
 
     protected function setUp()
     {
-        $this->_model = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create('Magento\Framework\Url');
+        $this->_model = Bootstrap::getObjectManager()->create('Magento\Framework\Url');
     }
 
     public function testSetGetUseSession()
@@ -77,6 +78,92 @@ public function testGetBaseUrlConfigured($params, $expectedUrl)
         $this->assertEquals($expectedUrl, $actualUrl);
     }
 
+    /**
+     * Note: isolation flushes the URL memory cache
+     * @magentoAppIsolation enabled
+     *
+     * @magentoConfigFixture current_store web/secure/base_url http://sample.com/
+     * @magentoConfigFixture current_store web/unsecure/base_link_url http://sample.com/
+     * @magentoConfigFixture current_store web/secure/base_link_url https://sample.com/
+     * @magentoConfigFixture current_store web/secure/use_in_frontend 1
+     *
+     * @magentoAppArea frontend
+     */
+    public function testGetUnsecureUrlInSecureArea()
+    {
+        /** @var \Magento\Framework\App\Request\Http $request */
+        $request = Bootstrap::getObjectManager()->create(\Magento\Framework\App\Request\Http::class);
+        //Emulate HTTPS request
+        $request->getServer()->set('HTTPS', 'on');
+        $request->getServer()->set('SERVER_PORT', 443);
+
+        $model = Bootstrap::getObjectManager()->create(\Magento\Framework\Url::class, ['request' => $request]);
+
+        $secureUrl = $model->getUrl('some/index/controller');
+        $this->assertStringStartsWith(
+            'https://sample.com/index.php/some/index/controller/',
+            $secureUrl,
+            'Default URL in secure area is incorrect'
+        );
+
+        $secureUrl = $model->getUrl('some/index/controller', ['_secure' => true]);
+        $this->assertStringStartsWith(
+            'https://sample.com/index.php/some/index/controller/',
+            $secureUrl,
+            'Secure URL in secure area is incorrect'
+        );
+
+        $unsecureUrl = $model->getUrl('some/index/controller', ['_secure' => false]);
+        $this->assertStringStartsWith(
+            'http://sample.com/index.php/some/index/controller/',
+            $unsecureUrl,
+            'Unsecure URL in secure area is incorrect'
+        );
+    }
+
+    /**
+     * Note: isolation flushes the URL memory cache
+     * @magentoAppIsolation enabled
+     *
+     * @magentoConfigFixture current_store web/secure/base_url http://sample.com/
+     * @magentoConfigFixture current_store web/unsecure/base_link_url http://sample.com/
+     * @magentoConfigFixture current_store web/secure/base_link_url https://sample.com/
+     * @magentoConfigFixture current_store web/secure/use_in_frontend 1
+     *
+     * @magentoAppArea frontend
+     */
+    public function testGetSecureUrlInUnsecureArea()
+    {
+        /** @var \Magento\Framework\App\Request\Http $request */
+        $request = Bootstrap::getObjectManager()->create(\Magento\Framework\App\Request\Http::class);
+        //Emulate HTTPS request
+        $request->getServer()->set('HTTPS', 'off');
+        $request->getServer()->set('SERVER_PORT', 80);
+
+        $model = Bootstrap::getObjectManager()->create(\Magento\Framework\Url::class, ['request' => $request]);
+
+        $secureUrl = $model->getUrl('some/index/controller', ['_nosid' => 1]);
+        $this->assertEquals(
+            'http://sample.com/index.php/some/index/controller/',
+            $secureUrl,
+            'Default URL in unsecure area is incorrect'
+        );
+
+        $secureUrl = $model->getUrl('some/index/controller', ['_secure' => true, '_nosid' => 1]);
+        $this->assertEquals(
+            'https://sample.com/index.php/some/index/controller/',
+            $secureUrl,
+            'Secure URL in unsecure area is incorrect'
+        );
+
+        $unsecureUrl = $model->getUrl('some/index/controller', ['_secure' => false, '_nosid' => 1]);
+        $this->assertEquals(
+            'http://sample.com/index.php/some/index/controller/',
+            $unsecureUrl,
+            'Unsecure URL in unsecure area is incorrect'
+        );
+    }
+
     /**
      * Check that url type is restored to default after call getBaseUrl with type specified in params
      */