-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Unable to generate unsecure URL if current URL is secure #6175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thank you for your submission. We recently made some changes to the way we process GitHub submissions to more quickly identify and respond to core code issues. Feature Requests and Improvements should now be submitted to the new Magento 2 Feature Requests and Improvements forum (see details here). We are closing this GitHub ticket and have moved your request to the new forum. |
Hi @piotrekkaminski, thanks for status update. But I'm not sure why is this one marked with an improvement tag when it's about already implemented feature, the _secure switch to \Magento\Framework\Url::getUrl whose functionality breaks under described circumstances aka a bug. |
I am also facing the same issue. Is this issue had been fixed? |
Marked as feature/improvement request therefore closed. Nevertheless still an issue within Magento 2.1.4 codebase: |
Ok, but in feature/improvement request also it is not resolved. This is a very disappointment thing that such a basic functionality is also not working. |
Internal ticket MAGETWO-62500 |
Please can anyone tell me how to check the status of internal ticket created MAGETWO-62500. |
I will check this |
…f current URL is secure
…ent URL is secure added inside
…ent URL is secure - code cleaned
…re URL if current URL is secure #10188 - changed flag to _secure_forced to be consistent with previous implementation
…re URL if current URL is secure #10188 - changed flag to _secure
…re URL if current URL is secure #10188 - added integration tests
…re URL if current URL is secure #10188 - fixed ingration test
…re URL if current URL is secure #10188
Internal ticket to track issue progress: MAGETWO-70591 |
Internal ticket to track issue progress: MAGETWO-70736 |
Preconditions
Steps to reproduce
Expected result
Reason behind such behavior is:
https://github.com/magento/magento2/blob/2.1.0/lib/internal/Magento/Framework/Url.php#L364-L366
where code assumes that if current request is secure, requested url should be secure as well, regardless to '_secure' parameter saying otherwise.
The text was updated successfully, but these errors were encountered: