Skip to content

Module names sorting issue? #10112

Closed
Closed
@magekey

Description

@magekey

Not sure it could be an issue but I found some problem during develop my module.

Preconditions

  1. Release 2.1.7 with Sample Data
  2. Ubuntu 16.04, php-fpm 5.6.30, MySql Percona Server 5.6

I did some tests with modules sorting function in \Magento\Framework\Module\ModuleList\Loader.
Here is results of print_r function.

TEST 1 - No custom modules.

Result:

Magento_Checkout - line 558 (Line in browser)
Magento_Tax - line 618


TEST 2 - added module MageKey_Module - no sequences

<module name="MageKey_Module" setup_version="2.1.0"/>

Result:

MageKey_Module - line 3
Magento_Checkout - line 568
Magento_Tax - line 628

looks correct


TEST 3 - added sequence

<module name="MageKey_Module" setup_version="2.1.0">
    <sequence>
        <module name="Magento_Checkout"/>
    </sequence>
</module>

Result:

Magento_Tax - line 511
Magento_Checkout - line 571
MageKey_Module - line 1073

now Magento_Checkout has high priority which is not good.


Not sure it can be an issue but I added only Checkout sequence, not sure why Tax has low priority now. As result I got an issue on Checkout cart page.

Expected result

On Checkout Cart page on summary sidebar to render Grand Total (grand-total) we are using component Magento_Tax/js/view/checkout/cart/totals/grand-total. Order Total shows correct info.

Actual result

When module has been added now we have checkout component Magento_Checkout/js/view/summary/grand-total. And Order Total collected without Taxes.

Not sure maybe I missed something.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions