Skip to content

Back in stock alert email not translatable #10997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mike-happy opened this issue Sep 22, 2017 · 1 comment
Closed

Back in stock alert email not translatable #10997

mike-happy opened this issue Sep 22, 2017 · 1 comment
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release

Comments

@mike-happy
Copy link

Preconditions

  1. Magento CE 2.1.9
  2. Products are set up.
  3. Stock is set up.
  4. Magento2translations (nl_NL) language package is installed and enabled.

Steps to reproduce

  1. Set the stock of a product on 0 and out of stock in the admin.
  2. Create a customer login in the frontend
  3. Navigate to the product that is out of stock
  4. Click on the link "Notify me when this product is in stock". ("Informeer mij wanneer dit product op voorraad is" in dutch)

Expected result

  1. Receive the email in Dutch, because the language package contains the right translations.

Actual result

  1. Receive the email in English.

screen shot 2017-09-15 at 09 04 21

The email is send through the cron, so it is only send at night. (Which makes debugging extra difficult)

The actual text is in magento/module-product-alert/view/frontend/templates/email/price.phtml
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Sep 22, 2017
@JeroenVanLeusden
Copy link
Member

Think cron translations are not loaded here, please check the fix in #8413. When having issues displaying the correct image in your email you can also check the fix in #10208.

@okorshenko okorshenko added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Sep 24, 2017
@magento-engcom-team magento-engcom-team added 2.1.x Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release labels Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@okorshenko @mike-happy @JeroenVanLeusden @magento-engcom-team