Skip to content

Duplicated elements id in checkout page #13415

Closed
@angelo983

Description

@angelo983

Preconditions

  1. Magento 2.1.10

Steps to reproduce

  1. Go to Stores -> Configuration -> Sales -> Sales under Gift Options and set both Allow Gift Messages to YES
  2. Put something in cart and go to checkout or cart page

Expected result

  1. Two forms for gift messages having fields with unique ids

Actual result

  1. Two forms for gift messages having fields with non unique ids
[DOM] Found 2 elements with non-unique id #gift-message-whole-from: (More info: https://goo.gl/9p2vKq) <input type=​"text" id=​"gift-message-whole-from" class=​"input-text" data-bind=​"value:​ getObservable('sender')​">​ <input type=​"text" id=​"gift-message-whole-from" class=​"input-text" data-bind=​"value:​ getObservable('sender')​">
[DOM] Found 2 elements with non-unique id #gift-message-whole-to: (More info: https://goo.gl/9p2vKq) <input type=​"text" id=​"gift-message-whole-to" class=​"input-text" data-bind=​"value:​ getObservable('recipient')​">​ <input type=​"text" id=​"gift-message-whole-to" class=​"input-text" data-bind=​"value:​ getObservable('recipient')​">​

Non unique ids alert appears too in checkout payment choice:

[DOM] Found 2 elements with non-unique id #billing-new-address-form: (More info: https://goo.gl/9p2vKq) <fieldset id=​"billing-new-address-form" class=​"fieldset address">​…​</fieldset>​ <fieldset id=​"billing-new-address-form" class=​"fieldset address">​…​</fieldset>​

Metadata

Metadata

Assignees

No one assigned

    Labels

    Component: CheckoutComponent: GiftMessageFixed in 2.2.xThe issue has been fixed in 2.2 release lineFixed in 2.3.xThe issue has been fixed in 2.3 release lineIssue: Clear DescriptionGate 2 Passed. Manual verification of the issue description passedIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentReproduced on 2.2.xThe issue has been reproduced on latest 2.2 releaseReproduced on 2.3.xThe issue has been reproduced on latest 2.3 releaseup for grabs

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions