Safari "Block all cookies" setting breaks JavaScript scripts

[krzksz]

Preconditions

1. Magento 2.2.2 but potentially all versions are affected
2. Block all cookies setting enabled in Safari privacy options.

Steps to reproduce

1. Open Safari browser and go to Preferences
2. In Privacy tab enable Block all cookies setting.
3. Open any Magento shop.

Expected result

1. At least the popup with "cookies disabled" message is being displayed.

Actual result

1. There are multiple SecurityError (DOM Exception 18): The operation is insecure. errors reported in browser's console, some of the scripts work but I can't add anything to the cart.

So it seems like having above setting enabled in Safari will result in above error every time any script is trying to access either window.localStorage or window.sessionStorage including reassigning it. As a result following lines throw errors and most probably prevent shop from functioning properly:

magento2/app/code/Magento/Theme/view/frontend/templates/js/polyfill.phtml

Line 128 in c06da29

window.localStorage.__proto__ = window.localStorage = new Storage('local');

magento2/app/code/Magento/Ui/view/base/web/js/lib/core/storage/local.js

Line 14 in 9c14af7

localStorage = window.localStorage,

and also this part of https://github.com/magento/magento2/blob/2.2-develop/lib/web/jquery/jquery.storageapi.min.js:

    function f(e) {
        if (!window[e]) // Error thrown here
            return !1;
        var t = "jsapi";
        try {
            return window[e].setItem(t, t), window[e].removeItem(t), !0
        } catch (r) {
            return !1
        }
    }

I am not sure what would be your preferred solution to this problem but I can gladly prepare a PR when we agree on how we should solve it 👍 .

[VladimirZaets]

Hi @krzksz, Magento can't correctly work in the case when cookies are disabled, but I agree that we should give some notification to the user about it. I think the solution with notification in modal window is ok. We should add JS script that will check cookie state when JS application is bootstrapping, for this we can use "cookieEnabled" property in navigation object.

[ishakhsuvarov]

Hi @krzksz
Are you still interested in preparing a PR for this case?

[raulvOnestic91]

@magento i am working on it

[m2-assistant]

Hi @raulvOnestic91! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and self-assign the issue.