Skip to content

StockRegistryInterface :: getLowStockItems() returns StockStatusCollection instead of StockItemCollection #15085

Closed
@jesse-dev

Description

@jesse-dev

Preconditions

  1. Magento 2.2.4
  2. This is a typo/mistake in the API, so the environment doesn't matter

Steps to reproduce

  1. call REST API : /V1/stockItems/lowStock/
  2. observe the response is \Magento\CatalogInventory\Api\Data\StockStatusCollectionInterface

Expected result

  1. return \Magento\CatalogInventory\Api\Data\StockItemCollectionInterface
  2. The implementation in Magento\CatalogInventory\Model\StockRegistry :: getLowStockItems() returns \Magento\CatalogInventory\Api\Data\StockItemCollectionInterface , so this is clearly a typo/mistake.

Actual result

  1. returns \Magento\CatalogInventory\Api\Data\StockStatusCollectionInterface
  2. The implementation in Magento\CatalogInventory\Model\StockRegistry :: getLowStockItems() returns \Magento\CatalogInventory\Api\Data\StockItemCollectionInterface , so this is clearly a typo/mistake.

The Fix

  1. the return docblock for getLowStockItems() in \Magento\CatalogInventory\Api\StockRegistryInterface just needs to be updated to return \Magento\CatalogInventory\Api\Data\StockItemCollectionInterface instead of \Magento\CatalogInventory\Api\Data\StockStatusCollectionInterface

Metadata

Metadata

Assignees

No one assigned

    Labels

    Component: CatalogInventoryFixed in 2.2.xThe issue has been fixed in 2.2 release lineFixed in 2.3.xThe issue has been fixed in 2.3 release lineIssue: Clear DescriptionGate 2 Passed. Manual verification of the issue description passedIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentReproduced on 2.2.xThe issue has been reproduced on latest 2.2 releaseReproduced on 2.3.xThe issue has been reproduced on latest 2.3 releasegood first issue

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions