Skip to content

extraneous margins on product list and product list items #15308

Closed
@DanielRuf

Description

@DanielRuf

Preconditions

  1. Magento 2.2.4

Steps to reproduce

  1. open list view of products on a page
  2. inspect the list .column.main .product-items and one product .products-list .product-item

Expected result

  1. there should not be any extraneous styles

Actual result

  1. there are negative and positive margins which do nothing combined

The following code would remove it:

.products-list .product-item {
    padding-left: 0;
  }
  .column.main .product-items {
    margin-left: 0;
  }

In general I see no sense in these margins and paddings.

See

.column.main {
.product {
&-items {
margin-left: -@indent__base;
}
&-item {
padding-left: @indent__base;
}
}
}

https://github.com/magento/magento2/blame/c0123f3bcaf3b3878b9b6e425f92f16468aaf87c/app/design/frontend/Magento/luma/Magento_Catalog/web/css/source/module/_listings.less#L167-L177

08b6a7f

Metadata

Metadata

Assignees

Labels

Fixed in 2.1.xThe issue has been fixed in 2.1 release lineFixed in 2.2.xThe issue has been fixed in 2.2 release lineFixed in 2.3.xThe issue has been fixed in 2.3 release lineIssue: Format is validGate 1 Passed. Automatic verification of issue format passedRelease Line: 2.2

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions