Skip to content

no navigation-level0-item__hover__color #15848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DanielRuf opened this issue Jun 5, 2018 · 8 comments
Closed

no navigation-level0-item__hover__color #15848

DanielRuf opened this issue Jun 5, 2018 · 8 comments
Assignees
@hitesh-wagento
Labels
Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line good first issue Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@DanielRuf
Copy link
Contributor

DanielRuf commented Jun 5, 2018 •
edited
Loading

We have @navigation-level0-item__active__color but no @navigation-level0-item__hover__color

Keep in mind that we also have hover on some devices and screens (resized browser window).
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Jun 5, 2018
@engcom-backlog-nickolas engcom-backlog-nickolas added Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed feature request labels Jul 11, 2018
@engcom-backlog-nickolas
Copy link

Hello @DanielRuf, thank you for your report.
GitHub is intended for bug reports, please use https://github.com/magento/community-features for other suggestions like improvements or feature requests.

@engcom-backlog-nickolas engcom-backlog-nickolas removed their assignment Jul 11, 2018
@engcom-backlog-nickolas engcom-backlog-nickolas added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Jul 11, 2018
@DanielRuf
Copy link
Contributor Author

This is an actual bugreport. There is a missing variable.

@DanielRuf DanielRuf reopened this Jul 11, 2018
@DanielRuf
Copy link
Contributor Author

I can also provide a PR then if no other developer wants to contribute to solve this easy issue.

@engcom-backlog-nickolas
Copy link

@DanielRuf, thank you for your feedback. You are right, my bad.

@hitesh-wagento
Copy link
Contributor

I am working on this PR

@hitesh-wagento hitesh-wagento self-assigned this Jul 11, 2018
@hitesh-wagento hitesh-wagento mentioned this issue Jul 12, 2018
Merged
4 tasks
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jul 13, 2018
@magento-engcom-team
Copy link
Contributor

Hi @DanielRuf. Thank you for your report.
The issue has been fixed in #16732 by @hitesh-wagento in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.6 release.

magento-engcom-team added a commit that referenced this issue Jul 13, 2018
@magento-engcom-team
ENGCOM-2288: Resolved : no navigation-level0-item__hover__color #15848 …
50c298c 
…#16732

 - Merge Pull Request #16732 from hitesh-wagento/magento2:navigation-hover
 - Merged commits:
   1. 1fbc2db
magento-engcom-team pushed a commit that referenced this issue Jul 13, 2018
ENGCOM-2288: Resolved : no navigation-level0-item__hover__color #15848 …
264729c 
…#16732
@hitesh-wagento hitesh-wagento mentioned this issue Jul 14, 2018
Merged
4 tasks
This was referenced Jul 14, 2018
Merged
Merged
hitesh-wagento added a commit to hitesh-wagento/magento2 that referenced this issue Jul 14, 2018
@hitesh-wagento
Merge pull request #26 from hitesh-wagento/2.1-develop-PR-port-16732
4fa3bbe 
[Backport] Resolved : no navigation-level0-item__hover__color magento#15848
@hitesh-wagento hitesh-wagento mentioned this issue Jul 14, 2018
Merged
4 tasks
hitesh-wagento added a commit to hitesh-wagento/magento2 that referenced this issue Jul 14, 2018
@hitesh-wagento
Revert "[Forwardport] Resolved : no navigation-level0-item__hover__co…
6b05aa7 
…lor magento#15848"
@sidolov
Copy link
Contributor

sidolov commented Jul 18, 2018

Hi @DanielRuf. Thank you for your report.
The issue has been fixed in #16797 by @hitesh-wagento in 2.1-develop branch
Related commit(s):

The fix will be available with the upcoming 2.1.15 release.

@sidolov sidolov added the Fixed in 2.1.x The issue has been fixed in 2.1 release line label Jul 18, 2018
magento-engcom-team added a commit that referenced this issue Jul 18, 2018
@magento-engcom-team
ENGCOM-2341: [Backport] Resolved : no navigation-level0-item__hover__…
dc864a1 
…color #15848 #16797

 - Merge Pull Request #16797 from hitesh-wagento/magento2:2.1-develop-PR-port-16732
 - Merged commits:
   1. faa9815
magento-engcom-team pushed a commit that referenced this issue Jul 18, 2018
ENGCOM-2341: [Backport] Resolved : no navigation-level0-item__hover__…
67ac088 
…color #15848 #16797
@magento-engcom-team
Copy link
Contributor

Hi @DanielRuf. Thank you for your report.
The issue has been fixed in #16796 by @hitesh-wagento in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jul 20, 2018
magento-engcom-team added a commit that referenced this issue Jul 20, 2018
@magento-engcom-team
ENGCOM-2340: [Forwardport] Resolved : no navigation-level0-item__hove…
8f49aef 
…r__color #15848 #16796

 - Merge Pull Request #16796 from hitesh-wagento/magento2:2.3-develop-PR-port-16732
 - Merged commits:
   1. 85caf63
magento-engcom-team pushed a commit that referenced this issue Jul 20, 2018
ENGCOM-2340: [Forwardport] Resolved : no navigation-level0-item__hove…
7c99baa 
…r__color #15848 #16796
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hitesh-wagento hitesh-wagento

Labels
Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line good first issue Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@DanielRuf @sidolov @hitesh-wagento @magento-engcom-team @engcom-backlog-nickolas