Skip to content

import new products via csv: products are created with empty value when strings are too long #17865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LouNik1984 opened this issue Aug 30, 2018 · 14 comments
Labels
Component: CatalogImportExport Event: mm18mx Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@LouNik1984
Copy link

Preconditions

magento 2.2.5 on ubuntu 16.04 with apache and php 7.1.2. Magento is a fresh install, no custom theme nor any custom module is installed. Magento has been installed by downloaded the source via composer and then run the wizard from browser.

Steps to reproduce

  1. prepare a correct csv to create new products via backend. Use short values (less then 71 characters) for name/sku for a few records, then use a longer strings ((more then 71 characters) for name/sku for other records.
  2. go to system > import:
    -- entity type = products
    -- import behaviour = add/update, skip error entries
    -- allow errors count = I tried with several numbers from 10 (default) to 500 but issue persists
    -- field separator = ; (semicolon)
    -- multiple value separator = , (comma, default)
    -- field enclosure = unchecked (default)
  3. Select the csv to import and run check data

Expected result

  • when strings are too long, I expect to see an error after I run check data. I also expect that import get blocked until all error are fixed so no products gets created until the check data allows you to proceed with the import.

Actual result

Actual results consists in two issues:

  1. Check data returns no error, so I'm able to proceed with the import. The import fails saying that there's been a system error. But I shouldn't be able to proceed since my csv contains values (the strings too long) that causes my import to fail.
  2. If I go to my product list, I can see that all the products with too long strings have been created but all the values exept sku are empty (see screenshots). Since the import has failed, no product should have been created.

SCREENSHOTS:

  1. check data returns no error:
    checkdata

  2. import fails because of the strings that are too long
    error

  3. my product list shows the products with empty values
    lista

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Aug 30, 2018
@magento-engcom-team
Copy link
Contributor

Hi @LouNik1984. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me {$VERSION} instance

where {$VERSION} is version tags (starting from 2.2.0+) or develop branches (2.2-develop +).
For more details, please, review the Magento Contributor Assistant documentation.

@LouNik1984 do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@LouNik1984
Copy link
Author

@magento-engcom-team give me 2.2.5 instance

@magento-engcom-team
Copy link
Contributor

Hi @LouNik1984. Thank you for your request. I'm working on Magento 2.2.5 instance for you

@magento-engcom-team
Copy link
Contributor

Hi @LouNik1984, here is your Magento instance.
Admin access: https://i-17865-2-2-5.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@ghost ghost self-assigned this Aug 30, 2018
@LouNik1984
Copy link
Author

I can confirm that I can reproduce the issue on the vanilla instance you gave me. I don't know the exact character limit so I used one of the record that I tried to import in my magento instance. In the vanilla instance, you can see a bunch of products correctly imported while the last one to be imported (id = 17) is the one with the too long string and you can see that values are empty.

I'll attach the csv file I have used to import the product which causes the issue. Because I cannot upload csv files, I transformed it in a txt but of course for magento I have used the csv version.

simple-products-import.txt

@ghost
Copy link

ghost commented Aug 30, 2018

@LouNik1984, thank you for your report.
We've acknowledged the issue and added to our backlog.

@ghost ghost added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Component: CatalogImportExport labels Aug 30, 2018
@ghost ghost removed their assignment Aug 30, 2018
@adityarshah
Copy link

I would like to work on this issue and hence starting work on this.

@gloriadg20
Copy link

#mm18mx

@magento-engcom-team
Copy link
Contributor

@gloriadg20 thank you for joining. Please accept team invitation here and self-assign the issue.

@gloriadg20
Copy link

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @gloriadg20. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @gloriadg20, here is your Magento instance.
Admin access: http://ec2-34-228-235-121.compute-1.amazonaws.com/i-17865-2-3-develop//admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@sidolov
Copy link
Contributor

sidolov commented Oct 27, 2018

Hi @LouNik1984. Thank you for your report.
The issue has been fixed in #18639 by @ravi-chandra3197 in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.1 release.

@sidolov sidolov added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Oct 27, 2018
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Oct 29, 2018
@magento-engcom-team
Copy link
Contributor

Hi @LouNik1984. Thank you for your report.
The issue has been fixed in #18591 by @ravi-chandra3197 in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.8 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: CatalogImportExport Event: mm18mx Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

6 participants