duplicate on (multi)select attribute breaks validation

[Schrank]

Preconditions (*)

Demo build on the demo store of basecom: https://www.basecom.de/magento2/demo
Magento Ver.-2.2.6

On (multi)select attributes it is possible to save duplicates. The validation is correct, but for some reason the list of options is hidden after validation and not validated again due to that.

Steps to reproduce (*)

1. Open product attribute "activity"
2. add new option "Urban"
   
   
3. Click on Save Attribute
4. Click a second time on "Save Attribute"

Expected result (*)

1. Error is shown on the two options
2. List of options does not vanish
3. after correction the attribute is saved WITHOUT duplicate

Actual result (*)

1. List of Attributes vanishes
   
2. See the error triangle on the tab on the left
3. The attribute is saved WITH duplicate

Might be connected to #7646

[magento-engcom-team]

Hi @Schrank. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@Schrank do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

[magento-engcom-team]

Hi @dmytro-ch. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

[magento-engcom-team]

@dmytro-ch Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-96743 were created

[dmytro-ch]

Hello @Schrank, thank you for the report.
I've reproduced the issue for latest Magento 2.2 version.
It also looks like the issue has been allready fixed for Magento 2.3.

[Schrank]

Good to read, thanks @dmytro-ch

[ghost]

Hi @dmytro-ch Will you create the pr to 2.2-dev ? or we can close as this was fixed in 2.3-develop ?

[Schrank]

I opt for option 1 :-)

If you have any indication (internal ticket number, external ticket number, ...) about the commit(s) which fixed the problem? Then I'm happy to send a PR (or fix it only in our install)

[dmytro-ch]

I've briefly checked the changes.

Here is the commits history for the app/code/Magento/Catalog/view/adminhtml/web/js/options.js file: https://github.com/magento/magento2/commits/2.3-develop/app/code/Magento/Catalog/view/adminhtml/web/js/options.js

Most likely, the issue has been fixed in the scope of the MAGETWO-94819 and MAGETWO-94962 internal tickets. There are a lot of changes done in many files.
https://github.com/magento/magento2/search?q=MAGETWO-94819&type=Commits
https://github.com/magento/magento2/search?q=MAGETWO-94962&type=Commits

The issue requires a deep investigation and we should also consider the bugs related to MAGETWO-94819 and MAGETWO-94962.
Unfortunately, I'm not sure how soon I would be able to get to this issue. So volunteers are welcome. 😃

[Schrank]

Hey, just to get the current status... It is fixed in 2.3 and it won't get fixed in 2.2, correct?

Totally fine to me, just want to make sure we are on the same page.