Extremely slow performance of "Extension Manager" when custom repo added to composer.json

[vovayatsyuk]

Summary

When some repo is added to the repositories section of composer.json file "Extension Manager" page start working extremely slow.

(I don't recommend to test it - magento has near 200 composer packages. An example below will trigger Magento to call composer show PACKAGE --available for every installed module.)

Examples

1. Open composer.json file in magento root.

2. Add or modify "repositories" section as follows:

   "repositories": {
       "swissup": {
           "type": "composer",
           "url": "https://docs.swissuplabs.com/packages/"
       },
       "magento": {
           "type": "composer",
           "url": "https://repo.magento.com/packages.json"
       }
   }
   

3. Navigate to backend System > Web Setup Wizard

4. The page will load extremely slow.

Proposed solution

I propose to do the following things in Magento/Setup/Model/PackagesData.php:

1. Don't call composer show for modules found in the marketplace:

@@ -476,21 +476,14 @@
      */
     private function getPackageAvailableVersions($package)
     {
-        $magentoRepositories = $this->composerInformation->getRootRepositories();
-
-        // Check we have only one repo.magento.com repository
-        if (count($magentoRepositories) === 1
-            && strpos($magentoRepositories[0], $this->packagesAuth->getCredentialBaseUrl()) !== false
-        ) {
-            $packagesJson = $this->getPackagesJson();
-
-            if (isset($packagesJson[$package])) {
-                $packageVersions = $packagesJson[$package];
-                uksort($packageVersions, 'version_compare');
-                $packageVersions = array_reverse($packageVersions);
-
-                return array_keys($packageVersions);
-            }
+        $packagesJson = $this->getPackagesJson();
+
+        if (isset($packagesJson[$package])) {
+            $packageVersions = $packagesJson[$package];
+            uksort($packageVersions, 'version_compare');
+            $packageVersions = array_reverse($packageVersions);
+
+            return array_keys($packageVersions);
         }
 
         return $this->getAvailableVersionsFromAllRepositories($package);

2. Don't process modules that are not from the marketplace:

@@ -486,7 +486,7 @@
             return array_keys($packageVersions);
         }
 
-        return $this->getAvailableVersionsFromAllRepositories($package);
+        return [];
     }
 
     /**

These changes intentionally remove support of the modules from packagist.org to prevent totally unusable "Extenstion Manager"

[m2-assistant]

Hi @vovayatsyuk. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@vovayatsyuk do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[engcom-Alfa]

Hello @vovayatsyuk . I can't reproducer this issue on 2.3 - develop and 2.2 - develop.