Cannot do second partial invoice after first partial invoice

Preconditions (*)

1. Magento 2.2.8
2. Braintree setup to authorize only

Steps to reproduce (*)

1. Add 2+ products to cart
2. Order products as guest using Credit Card
3. In order admin, invoice for 1 item, This should go through fine
4. Invoice again for 1 more item. Error will occur

Expected result (*)

1. Second invoice should go through same as the first

Actual result (*)

1. Second invoice does not go through

It looks like the capture strategy that is selected is VAULT_CAPTURE but this cannot work for guests, as their card details are not stored and therefore $paymentToken = $extensionAttributes->getVaultPaymentToken(); returns null

I believe the capture strategy should be CAPTURE but if this is used, the checks done in CaptureStrategyCommand class won't pick this strategy.

Looks like the logic

if (!$existsCapture && !$this->isExpiredAuthorization($payment, $paymentDO->getOrder())) {
            return self::CAPTURE;
        }

is wrong, but if i force this strategy, further errors are encountered, with a response saying the transaction status in Braintree needs to be authorized but it'll likely be on submitted_for_settlement because the initial invoice was raised.

[m2-assistant]

Hi @paul-gene. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@paul-gene do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[m2-assistant]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

Hello @paul-gene. Could You please try to reproduce Your issue not on 2.2.8 but on the fresh, vanilla 2.3-develop instance as You are advised to do in one of the above bot's comments. Thank You.

@magento give me 2.3-develop instance

[magento-engcom-team]

Hi @paul-gene. Thank you for your request. I'm working on Magento 2.3-develop instance for you

[magento-engcom-team]

Hi @paul-gene, here is your Magento instance.
Admin access: https://i-23946-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@magento give me 2.2-develop instance

[magento-engcom-team]

Hi @paul-gene. Thank you for your request. I'm working on Magento 2.2-develop instance for you

OK, so it looks like this cannot be replicated on a fresh install, due to another bug in Braintree.

In core Braintree, card details are stored regardless of whether the config is set not to store cards.

https://github.com/magento/magento2/blob/2.3-develop/app/code/Magento/Braintree/Gateway/Request/VaultDataBuilder.php#L33

Because this is always true, everyones cards are stored in the DB, regardless of the config settings, and therefore the capture strategy of VAULT_CAPTURE works.

If the VaultDataBuilder class is "fixed" to stop cards being stored all the time, then the VAULT_CAPTURE strategy will not work for a 2nd invoice, as no token is in the DB.

[engcom-Bravo]

Hello again @paul-gene. As we can conclude taking into consideration Your comment to Your another issue this issue must also have been fixed by #19767 in 2.3-develop version. So due to our workflow we are closing it now. Please feel free to reopen if deem necessary.