Card stored for customers despite Vault being disabled in Payment config

Preconditions (*)

1. Magento 2.3

Steps to reproduce (*)

1. Ensure vault is disabled for Braintree
2. Create customer account and login
3. Order a product and use Credit Card via Braintree (note that no option to save card is present)
4. Goto account and click Store Payment Methods

Expected result (*)

1. No stored payment methods should exist

Actual result (*)

1. Previously used card is stored in customers account

[m2-assistant]

Hi @paul-gene. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@paul-gene do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

Related to #23946

[m2-assistant]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

Hello again @paul-gene. We followed the steps You provided in this issue and here is what we have after the the order has been placed:

It's fixed in 2.3-develop by #19767

It affects 2.3.1 and I imagine any 2.2.x version.

The reason is because the default value set for is_visible is set to 1 for some odd reason. The logic in the vault observer uses a check to see if the "save for later" value is set, which it isn't if you have the vault option turned off in the Braintree config. The above PR addresses this.

What can we do about 2.3.1 and 2.2x?

[engcom-Bravo]

Hello @paul-gene. 2.2-develop branch was closed and Magento no longer accepts pull requests and issues to the v2.2 release lines to focus all development efforts on v2.3._
See Accepted pull requests and ported code for more details. As for 2.3.x versions - if the bug has been fixed in current develop version this fix becomes available only starting from the next release version. Thank You for applying.

@engcom-Bravo does that mean 2.2 will never get fixed?

[engcom-Bravo]

Yes @paul-gene, unfortunately it means exactly that. I'm not sure if it equally concerns Enterprise Edition as well, but as for Community Edition (this repository is intended for) everything is just like that.