[Magento 2.3.x] Data/Schema Patches getAliases() causes errors during setup:upgrade

[PauloPhagula]

Preconditions (*)

Project Environment

Magento 2.4-develop
Magento Version: 2.3.x CE
PHP: 7.4
Database: MySQL 8.0
OS: CentOS 7
Caching: Varnish Cache and OPcache

Steps to reproduce (*)

1. Create a schema patch with a class name e.g. ExampleSchemaPatch
2. Add a logger inside the apply method for the schema patch class to indicate that the apply method was executed
3. Run setup:upgrade
4. Check the patch_list table a fully qualified class name for the patch class would be present
5. Check the log file to confirm that the apply method for the patch was executed
6. Now change the class name of the applied patch to some something else e.g. ChangedExampleSchemaPatch
7. Added the old class name as an array item for the return array for the getAliases() method

public function getAliases()
{
    return [
        ExampleSchemaPatch::class
    ];
}

8. Run setup upgrade one more time

Expected result (*)

1. The second setup:upgrade should run normally with no errors whatsoever

Actual result (*)

1. setup:upgrade fails while applying patch. Mentioning that the original (now aliased) patch has already been applied

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @dareenzo. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant]

Hi @engcom-Alfa. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[magento-engcom-team]

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-40253 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[gowrizrh]

I kind of ran into the same problem and I'm having this same exact issue.

[Coosos]

Hello, no update on this PR #31635 ?

[ivanaugustobd]

We've included a workaround for this through the Discorgento Migrations module. Starting from v2.3.0 it will skip patches whose aliases were already applied, respecting your getAliases() method. 😉

Demo for those who don't know it yet: https://odysee.com/@discorgento:8/Introduction-to-Module-Migrations-Magento-discorgento-module-migrations:a