Underscores not allowed in module names in \Magento\Framework\App\Utility\Files::accumulateThemeStaticFiles

[bentideswell]

PSR-4 dictates that underscores have no special meaning and can be used in module names. There have been multiple PRs accepted for this bug in other areas of Magento but this one has been missed.

This is in \Magento\Framework\App\Utility\Files::accumulateThemeStaticFiles. This method collates static files from your theme. The bug means that it's not possible to extend a static file from a module that has an underscore in the module name (eg. FishPig_WordPress_IntegratedSearch).

Preconditions (*)

1. Magento 2.4.2 - but this is probably present in all versions from 2.0.0

Steps to reproduce (*)

1. Install Magento 2.4.2
2. Extend a CSS file from a module with an underscore in the module name (app/design/frontend/YourVendor/YourTheme/ThirdParty_Module_Test/web/css/source/_module.less)
3. Compile the static assets

Expected result (*)

The _module.less is processed correctly

Actual result (*)

Error happened during deploy process: Could not parse theme static file '/var/www/test-siteapp/design/frontend/YourVendor/YourTheme/ThirdParty_Module_Test/web/css/source/_module.less'

---

• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.

[m2-assistant]

Hi @bentideswell. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[bentideswell]

I have created a PR for this.

[m2-assistant]

Hi @engcom-Oscar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[gabrieldagama]

Hi @bentideswell. Thank you for your report.
The issue has been fixed in #32620 by @bentideswell in 2.4-develop branch
Related commit(s):

• a3b124a773061d59fbce5a4efb5cd7b3479f6db0
• e17a3e7fb9b26510a6102a654253bab0c0d0d072
• df94b8aef4a8c59a04dc432d286cec172e99500b
• 696f7ee63784e6d549d5d2b2ad39b649b1812cc5
• 96f58e78e750452475dcae0f1f8d2a86fc78de41
• 87c4a75b98d3e7e6d98885f231fef3d035b76587

The fix will be available with the upcoming 2.4.3 release.