Skip to content

File Uploader initialization #344

Closed
Closed
@trongrg

Description

@trongrg
app/code/Mage/Backend/Model/Config/Backend/File.php
95:                $uploader = new Mage_Core_Model_File_Uploader($file);

app/code/Mage/Catalog/Model/Category/Attribute/Backend/Image.php
63:            $uploader = new Mage_Core_Model_File_Uploader($this->getAttribute()->getName());

app/code/Mage/Catalog/Model/Resource/Product/Attribute/Backend/Image.php
56:            $uploader = new Mage_Core_Model_File_Uploader($this->getAttribute()->getName());

app/code/Mage/Cms/Model/Wysiwyg/Images/Storage.php
325:        $uploader = new Mage_Core_Model_File_Uploader('image');

app/code/Mage/Downloadable/controllers/Adminhtml/Downloadable/FileController.php
53:            $uploader = new Mage_Core_Model_File_Uploader($type);

Those lines should be changed to use Mage::getModel instead of a direct 'new' keyword.

This will allow developers to easily implement new changes in File Uploader model.

I would love to provide the patch if necessary.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions