Skip to content

PLP - Total count is not working when it exceeds 10,000 #37556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 5 tasks
santhiya-nits opened this issue May 29, 2023 · 9 comments
Closed
1 of 5 tasks

PLP - Total count is not working when it exceeds 10,000 #37556

santhiya-nits opened this issue May 29, 2023 · 9 comments
Assignees
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.5-p1 Indicates original Magento version for the Issue report. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@santhiya-nits
Copy link

Preconditions and environment

Magento version - 2.4.5-P1

Path Name: vendor/magento/module-catalog/Block/Product/ProductList/Toolbar.php
Function Name: getTotalNum()

The getTotalNum() function does not fetch more than 10,000 data.

Steps to reproduce

Magento version - 2.4.5-P1

Path Name: vendor/magento/module-catalog/Block/Product/ProductList/Toolbar.php
Function Name: getTotalNum()

The getTotalNum() function does not fetch more than 10,000 data.

Expected result

Fetch the data more than 10,000

Actual result

If the database contains more than 10,000 records.
It fetches only 10,000 items not more than that.

Additional information

No response

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented May 29, 2023

Hi @santhiya-nits. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@engcom-Bravo engcom-Bravo added Reported on 2.4.5-p1 Indicates original Magento version for the Issue report. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it labels May 29, 2023
@engcom-Hotel engcom-Hotel self-assigned this May 29, 2023
@m2-assistant
Copy link

m2-assistant bot commented May 29, 2023

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Hotel
Copy link
Contributor

Hello @santhiya-nits,

Thanks for the report and collaboration!

We have tried to reproduce the issue in the 2.4-develop branch but the issue is not reproducible for us. It might be possible the issue got resolved.

We request you to please try to reproduce it in 2.4-develop and if the issue is reproducible for you then please let us know the proper steps to reproduce the issue.

Thanks

@engcom-Hotel engcom-Hotel added the Issue: needs update Additional information is require, waiting for response label May 29, 2023
@santhiya-nits
Copy link
Author

Hi,

Step 1: I tried to call the function getTotalNum() from the vendor/magento/module-catalog/Block/Product/ProductList/Toolbar.php. It does not return more than 10,000 records.
Note: In my database contain more than 10,000 records

@MTheProgrammer
Copy link
Contributor

This might help:
#8477 (comment)

@engcom-Hotel
Copy link
Contributor

Hello @santhiya-nits,

Thanks for the reply!

@MTheProgrammer Thanks for that reference!

But it seems this is the expected behavior of Magento in order to maintain the performance of e-commerce. You can also customize the same from the below file:

Also please go through with the comment below:
#8477 (comment)

Thanks

@engcom-Hotel
Copy link
Contributor

Hello @santhiya-nits,

Have you got a chance to check this comment #37556 (comment)?

Thanks

@engcom-Hotel
Copy link
Contributor

Hello @santhiya-nits,

We have noticed that this issue has not been updated.

Hence we assume that this issue is fixed now, so we are closing it. Please raise a fresh ticket or reopen this ticket if you need more assistance on this.

Regards

@santhiya-nits
Copy link
Author

santhiya-nits commented Jun 20, 2023

Hi,

Based on the comment #8477.
I changed the value from 10,000 to 30,000. still, it could not fetch data of more than 10,000

File Name: vendor/magento/module-catalog-search/etc/search_request.xml
Code : 10000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.5-p1 Indicates original Magento version for the Issue report. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
None yet
Development

No branches or pull requests

4 participants