Skip to content

Weird issue with custom shipping module #4142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MagePsycho opened this issue Apr 13, 2016 · 4 comments
Closed

Weird issue with custom shipping module #4142

MagePsycho opened this issue Apr 13, 2016 · 4 comments
Labels
bug report Fixed in 2.1.x The issue has been fixed in 2.1 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@MagePsycho
Copy link
Contributor

Whenever you use the custom shipping method code to be $_code = <vendor>_<module>, you get an error:

Please choose shipping method

while placing an order (during checkout payment) page.

It working fine when you use the code to be <module> only.
Is this a bug? I would love to have the code to be <vendor>_<module> in order to avoid the conflict with other extensions.
@ishakhsuvarov
Copy link
Contributor

@MagePsycho Thank you for reporting. Could you please provide more information regarding names you use? Any special characters in <vendor> or <module> values?

@ishakhsuvarov ishakhsuvarov self-assigned this Apr 14, 2016
@MagePsycho
Copy link
Contributor Author

I am using $_code = 'magepsycho_customshipping'

And code being used as:
$method->setCarrier($this->getCarrierCode()); $method->setMethod($this->getCarrierCode());

@piotrekkaminski
Copy link
Contributor

internal issue MAGETWO-53438

@ishakhsuvarov ishakhsuvarov added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report and removed Progress: needs update labels May 25, 2016
@vkorotun vkorotun removed the CS label Aug 4, 2016
@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Sep 11, 2017
@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Dec 5, 2017
@magento-engcom-team
Copy link
Contributor

@MagePsycho, thank you for your report.
The issue is already fixed in 2.1.10

@magento-engcom-team magento-engcom-team added Fixed in 2.1.x The issue has been fixed in 2.1 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Dec 5, 2017
magento-engcom-team pushed a commit that referenced this issue May 2, 2019
@viktym
Merge pull request #4142 from magento-mpi/PR-2019-4-29
1cc6e75 
MPI bug fix 2.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug report Fixed in 2.1.x The issue has been fixed in 2.1 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@MagePsycho @piotrekkaminski @ishakhsuvarov @vkorotun @magento-engcom-team