Skip to content

Improve oAuth Integration Identity Link Popup #4457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jim5359 opened this issue May 11, 2016 · 4 comments
Closed

Improve oAuth Integration Identity Link Popup #4457

jim5359 opened this issue May 11, 2016 · 4 comments
Assignees
Labels
Component: Framework/Webapi USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog WEB API use just Catalog improvement

Comments

@jim5359
Copy link

jim5359 commented May 11, 2016

Steps to reproduce

  1. Install Magento from develop branch.
  2. In Magento Admin: System > Extensions > Integrations click Add New Integration.
  3. Enter an integration name, email address, callback url and identity link url.
  4. Click API tab on the left and choose Resource Access All.
    Click Save.
  5. The new integration displays in the list of integrations. Click the "Authorize" link for the new integration.
  6. Verify API authorizations and click the Authorize button.

Expected result

  1. Popup should appear containing the contents of the Identity Link URL.

Actual result

  1. Nothing happens unless you disable the popup blocker.
  2. There is not even a notification that the popup was blocked.

Need to improve the flow so the popup avoids the popup blocker. As long as the popup is a direct response to a user action it will not trigger the popup blocker.

Another option is to use an iFrame.

@maksek maksek added Component: Framework/Webapi USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog WEB API use just Catalog PS labels May 11, 2016
@maksek maksek added the PROD label May 11, 2016
@choukalos choukalos assigned mbrinton01 and unassigned choukalos May 11, 2016
@choukalos
Copy link

Internal ticket to improve this flow - MAGETWO-52007 ; reassigning to Mark

@sevos1984
Copy link
Contributor

@jim5359 We can't reproduce this issue. Is it still actual?

@jim5359
Copy link
Author

jim5359 commented Jul 27, 2016

Yes, this is fixed in the current version. It now warns you if you have a popup blocker enabled.

@slavvka
Copy link
Member

slavvka commented Jul 28, 2016

Thank you, closing

@slavvka slavvka closed this as completed Jul 28, 2016
magento-engcom-team pushed a commit that referenced this issue Jul 11, 2019
[mpi] MAGETWO-99716: Limit list of type ahead suggested terms for Search keyword; currently the list can go over 100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Framework/Webapi USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog WEB API use just Catalog improvement
Projects
None yet
Development

No branches or pull requests

6 participants