Magnifier doesn't work with mode set to inner

[theycallmepepper]

This appears to be the original library that was ported over magnifier.js which offers the option of setting mode to 'inside' for an in-frame zoom.

In the etc/view.xml for the theme if you set the following the zoom does not work as expected:
<var name="magnifier"> <var name="mode">inside</var> <var name="eventType">hover</var> <var name="enabled">true</var> </var>
Instead of an in-frame zoom the lens does not appear. If you change mode back to outside it functions as expected.

Also,
https://github.com/magento/magento2/blob/develop/lib/web/magnifier/magnifier.js#L214 --unreachable if statement.

[guz-anton]

Hi @theycallmepepper
We will do investigation under MAGETWO-55440 internal ticket.

Thanks for pointing to issue.

[minhluan259]

I've enabled magnifier zoom in
vendor\magento\theme-frontend-luma\etc\view.xml
I'm notice it doesn't work on
magento 2.1.2 with sampledata (php 7.0.10, mysql 5.7)

       <var name="magnifier">
            <var name="fullscreenzoom">5</var>  <!-- Zoom for fullscreen (integer)-->
            <var name="top"></var> <!-- Top position of magnifier -->
            <var name="left"></var> <!-- Left position of magnifier -->
            <var name="width"></var> <!-- Width of magnifier block -->
            <var name="height"></var> <!-- Height of magnifier block -->
            <var name="eventType">hover</var> <!-- Action that atcivates zoom (hover/click) -->
            <var name="enabled">true</var> <!-- Turn on/off magnifier (true/false) -->
        </var>

[LSERRE]

I also notified this issue. I found a quick fixe for it: just set left to 0 and top to 0 and use default mode.

[artlesshand]

Any updates on this issue?

[lingwooc]

I've patched/replaced a couple of files in this module. The important bits are the css and the js which you could just throw in your theme (here). It also makes the magnifier work on touch screen laptops which it rather naively disables normally.

@LSERRE IIRC you also need a tweak to make sure a click on the now magnified image gives you a "fullscreen" view (assuming you have that enabled). That's in the module above as well.

[artlesshand]

Thanks @lingwooc