Skip to content

validation strings In lib/web/mage/validation.js are not translatable #6141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Rickywils opened this issue Aug 12, 2016 · 14 comments
Closed
Assignees
Labels
bug report Event: distributed-cd Distributed Contribution Day Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@Rickywils
Copy link

  1. Magento version 2.0.7

Steps to reproduce

  1. Try to translate these strings

Expected result

  1. Make all the strings translatable with $.mage__(' ')

Actual result

  1. Strings are not translatable at all.

Made a pull request for "validate-email".

#6140

@BeatDirector
Copy link

Magento 2.1.1
I tried $.mage.('Please enter a valid email address (Ex: [email protected]).') and it works with de_DE.csv.
Adding $.mage.
() should be added by default in js core files.

@tkn98
Copy link
Contributor

tkn98 commented Oct 5, 2016

X-Ref:

@maksek
Copy link
Contributor

maksek commented Feb 13, 2017

The fixed will be delivered in 2.0.15 and 2.1.7, 2.2.0.

@maksek maksek added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Feb 13, 2017
@tkn98
Copy link
Contributor

tkn98 commented Feb 14, 2017

@maksek: What is the ETA of these releases?

@tkn98
Copy link
Contributor

tkn98 commented Feb 14, 2017

And can you provide the commits where this went in for reference? Thanks for all your efforts.

@grasdaggel
Copy link

Is there any hotfix for this? We cannot go live with several shops due to this fatal bug.

@tkn98
Copy link
Contributor

tkn98 commented Mar 1, 2017

If the commits would be linked, this would be the patch (hotfix). Still not yet. Commits anyone?

@tkn98
Copy link
Contributor

tkn98 commented Mar 1, 2017

@maksek: Ping :)

@mavr1982
Copy link

Commits?

@mavr1982
Copy link

any news?

@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed PROD labels Sep 11, 2017
@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Oct 26, 2017
@magento-engcom-team
Copy link
Contributor

@Rickywils, thank you for your report.
We've created internal ticket(s) MAGETWO-82815 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 26, 2017
@magento-engcom-team magento-engcom-team added the Event: distributed-cd Distributed Contribution Day label Mar 19, 2018
@MikeParkin
Copy link

Looking at this as part of #distributed-cd

@magento-engcom-team
Copy link
Contributor

@MikeParkin thank you for joining. Please accept team invitation here and self-assign the issue.

@MikeParkin MikeParkin self-assigned this Mar 24, 2018
@MikeParkin
Copy link

Checking the history of lib/web/mage/validation.js it appears that translations for all of the strings has been added on 2.1, 2.2 and 2.3:

2.1-develop bd63082
2.2-develop/2.3 3109c8e

Going to close this issue.

magento-engcom-team pushed a commit that referenced this issue Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Event: distributed-cd Distributed Contribution Day Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

10 participants